[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Add result variable to make it possible to know that a CALENDAR_WRI
From: "junky" <reviewboard () asterisk ! org>
Date: 2012-01-27 4:02:31
Message-ID: 20120127040231.17168.53162 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1692/#review5324
-----------------------------------------------------------
Ship it!
Since there's no more write, sounds good to me.
- junky
On Jan. 26, 2012, 7:33 a.m., Terry Wilson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1692/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2012, 7:33 a.m.)
>
>
> Review request for Asterisk Developers and junky.
>
>
> Summary
> -------
>
> This patch adds a CALENDAR_SUCCESS=1/0 variable that is set to show whether or not \
> CALENDAR_WRITE has passed. This patch is basically junky's patch from the issue \
> with CALENDAR_SUCCESS=1/0 instead of CALENDARSTATUS="SUCCESS"/"FAILURE" so that one \
> can just do GotoIf(${CALENDAR_SUCCESS}?success:failure). Also changed is adding \
> some debugging for caldav PUT responses and not treating responses with no body as \
> an error (as a PUT gets a 201 Created with no body).
>
> This addresses bug ASTERISK-16903.
> https://issues.asterisk.org/jira/browse/ASTERISK-16903
>
>
> Diffs
> -----
>
> /trunk/res/res_calendar.c 352510
> /trunk/res/res_calendar_caldav.c 352510
> /trunk/res/res_calendar_exchange.c 352510
>
> Diff: https://reviewboard.asterisk.org/r/1692/diff
>
>
> Testing
> -------
>
> Wrote to a caldav calendar and verified proper creation of event and \
> CALENDAR_SUCCESS values.
>
> Thanks,
>
> Terry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1692/">https://reviewboard.asterisk.org/r/1692/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since there's no \
more write, sounds good to me.</pre> <br />
<p>- junky</p>
<br />
<p>On January 26th, 2012, 7:33 a.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and junky.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2012, 7:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a CALENDAR_SUCCESS=1/0 variable that is set to show \
whether or not CALENDAR_WRITE has passed. This patch is basically junky's patch \
from the issue with CALENDAR_SUCCESS=1/0 instead of \
CALENDARSTATUS="SUCCESS"/"FAILURE" so that one can just do \
GotoIf(${CALENDAR_SUCCESS}?success:failure). Also changed is adding some debugging \
for caldav PUT responses and not treating responses with no body as an error (as a \
PUT gets a 201 Created with no body).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wrote to a caldav calendar and verified proper creation of event and \
CALENDAR_SUCCESS values.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16903">ASTERISK-16903</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_calendar.c <span style="color: grey">(352510)</span></li>
<li>/trunk/res/res_calendar_caldav.c <span style="color: grey">(352510)</span></li>
<li>/trunk/res/res_calendar_exchange.c <span style="color: \
grey">(352510)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1692/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic