'Re: [asterisk-dev] [Code Review] Allow specifying which MixMonitor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Allow specifying which MixMonitor
From:       "telecos82" <reviewboard () asterisk ! org>
Date:       2011-12-27 14:39:24
Message-ID: 20111227143924.2434.31309 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1643/
-----------------------------------------------------------

(Updated Dec. 27, 2011, 8:39 a.m.)

Review request for Asterisk Developers.

Changes
-------

Change implementation to use mixmonitor_ds structure memory address as uniq=
ue identifier of mixmonitor for current channel. Add a new option "i" to sp=
ecify a channel variable to store that value

Summary
-------

Currently, if there are several MixMonitor started on a channel, there is n=
o way to specify which MixMonitor to stop with StopMixMonitor. With this pa=
tch we will allow this. One limitation of current implementation was that m=
ixmonitor datastore was not identified with a uid so there was no way to id=
entify a concrete MixMonitor. Furthermore, when retrieving audiohook to det=
tach from channel, there was no control on which audiohook to dettach, it a=
lways got first audiohook found of type mixmonitor_spy_type. With this patc=
h we are identifying MixMonitor datastore by the filename asociated to it, =
and dettaching the concrete audiohook contained on datastore. Furthermore a=
 new CLI command "mixmonitor list <channel_name>" to help querying active m=
ixmonitors on a channel.

This addresses bug ASTERISK-19096.
    https://issues.asterisk.org/jira/browse/ASTERISK-19096

Diffs (updated)
-----

  http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c 348737 =

Diff: https://reviewboard.asterisk.org/r/1643/diff

Testing
-------

Thanks,

telecos82

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1643/">https://reviewboard.asterisk.org/r/1643/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By telecos82.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2011, 8:39 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change implementation to use mixmonitor_ds structure memory address as \
unique identifier of mixmonitor for current channel. Add a new option &quot;i&quot; \
to specify a channel variable to store that value</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, if there are several MixMonitor started on a channel, there \
is no way to specify which MixMonitor to stop with StopMixMonitor. With this patch we \
will allow this. One limitation of current implementation was that mixmonitor \
datastore was not identified with a uid so there was no way to identify a concrete \
MixMonitor. Furthermore, when retrieving audiohook to dettach from channel, there was \
no control on which audiohook to dettach, it always got first audiohook found of type \
mixmonitor_spy_type. With this patch we are identifying MixMonitor datastore by the \
filename asociated to it, and dettaching the concrete audiohook contained on \
datastore. Furthermore a new CLI command &quot;mixmonitor list \
&lt;channel_name&gt;&quot; to help querying active mixmonitors on a channel.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-19096">ASTERISK-19096</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c <span \
style="color: grey">(348737)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1643/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 