[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: fix regression after rev 336294
From: "Kevin Fleming" <reviewboard () asterisk ! org>
Date: 2011-12-23 18:19:46
Message-ID: 20111223181946.16105.31989 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2011, noon, Matt Jordan wrote:
> > team/schmidts/unleash-the-beast/main/rtp_engine.c, lines 914-915
> > <https://reviewboard.asterisk.org/r/1640/diff/1/?file=22384#file22384line914>
> >
> > While this may fix this particular problem, I'm not sure it was ever expected \
> > that an AST_CONTROL_UPDATE_RTP_PEER frame would be handled in an RTP local \
> > bridge.
> > There are two instances where the AST_CONTROL_UPDATE_RTP_PEER frame will be \
> > queued up: 1. When processing a 200 OK response to a re-invite request where T38 \
> > is disabled 2. When processing a re-INVITE request with T38 disabled, after \
> > sending a 100 Trying and 200 OK
> > The question is: should we be queueing this frame in the presence of any \
> > re-invite that meets these criteria, or only if direct media is enabled?
While it may be true that those are the only two cases where that control frame is \
currently generated, that is not an appropriate definition of its semantics. The \
purpose of this control frame is to indicate that the other RTP endpoint has changed \
in some material way (address/port, format, etc), so that any \
bridge/application/channel that is connected to it can react appropriately.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1640/#review5075
-----------------------------------------------------------
On Dec. 22, 2011, 3:58 a.m., schmidts wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1640/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2011, 3:58 a.m.)
>
>
> Review request for Asterisk Developers and jrose.
>
>
> Summary
> -------
>
> with adding the AST_CONTROL_UPDATE_RTP_PEER control frame music on hold stoped \
> working when a call was put on hold. The problem was that the control frame was \
> only handled when received in a remote_bridge but not in a local_bridge. By adding \
> the handling of the UPDATE_RTP_PEER frame also to local_bridge moh works again.
>
> This addresses bug ASTERISK-19095.
> https://issues.asterisk.org/jira/browse/ASTERISK-19095
>
>
> Diffs
> -----
>
> team/schmidts/unleash-the-beast/main/rtp_engine.c 348832
>
> Diff: https://reviewboard.asterisk.org/r/1640/diff
>
>
> Testing
> -------
>
> tested several calls. Moh is working again when a call is put on hold.
>
>
> Thanks,
>
> schmidts
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1640/">https://reviewboard.asterisk.org/r/1640/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2011, noon, <b>Matt Jordan</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1640/diff/1/?file=22384#file22384line914" \
style="color: black; font-weight: bold; text-decoration: \
underline;">team/schmidts/unleash-the-beast/main/rtp_engine.c</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
enum ast_bridge_result local_bridge_loop(struct ast_channel *c0, struct ast_channel \
*c1, struct ast_rtp_instance *instance0, struct ast_rtp_instance *instance1, int \
timeoutms, int flags, struct ast_frame **fo, struct ast_channel **rc, void *pvt0, \
void *pvt1)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">914</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">fr</span><span \
class="o">-></span><span class="n">subclass</span><span class="p">.</span><span \
class="n">integer</span> <span class="o">!=</span> <span \
class="n">AST_CONTROL_UPDATE_RTP_PEER</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">913</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ast_indicate_data</span><span class="p">(</span><span \
class="n">other</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">subclass</span><span class="p">.</span><span \
class="n">integer</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">data</span><span class="p">.</span><span \
class="n">ptr</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">datalen</span><span \
class="p">);</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">915</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">ast_indicate_data</span><span class="p">(</span><span \
class="n">other</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">subclass</span><span class="p">.</span><span \
class="n">integer</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">data</span><span class="p">.</span><span \
class="n">ptr</span><span class="p">,</span> <span class="n">fr</span><span \
class="o">-></span><span class="n">datalen</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While this may fix this \
particular problem, I'm not sure it was ever expected that an \
AST_CONTROL_UPDATE_RTP_PEER frame would be handled in an RTP local bridge.
There are two instances where the AST_CONTROL_UPDATE_RTP_PEER frame will be queued \
up: 1. When processing a 200 OK response to a re-invite request where T38 is disabled
2. When processing a re-INVITE request with T38 disabled, after sending a 100 Trying \
and 200 OK
The question is: should we be queueing this frame in the presence of any re-invite \
that meets these criteria, or only if direct media is enabled?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While it \
may be true that those are the only two cases where that control frame is currently \
generated, that is not an appropriate definition of its semantics. The purpose of \
this control frame is to indicate that the other RTP endpoint has changed in some \
material way (address/port, format, etc), so that any bridge/application/channel that \
is connected to it can react appropriately.</pre> <br />
<p>- Kevin</p>
<br />
<p>On December 22nd, 2011, 3:58 a.m., schmidts wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and jrose.</div>
<div>By schmidts.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2011, 3:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">with adding the AST_CONTROL_UPDATE_RTP_PEER control frame music on hold \
stoped working when a call was put on hold. The problem was that the control frame \
was only handled when received in a remote_bridge but not in a local_bridge. By \
adding the handling of the UPDATE_RTP_PEER frame also to local_bridge moh works \
again.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested several calls. Moh is working again when a call is put on \
hold.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19095">ASTERISK-19095</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/schmidts/unleash-the-beast/main/rtp_engine.c <span style="color: \
grey">(348832)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1640/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic