[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Get CDR Congestion Logging Test
From: "mjordan" <reviewboard () asterisk ! org>
Date: 2011-11-30 17:04:42
Message-ID: 20111130170442.12338.51440 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1552/#review4890
-----------------------------------------------------------
Ship it!
Looks good
- mjordan
On Nov. 30, 2011, 10:52 a.m., jrose wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1552/
> -----------------------------------------------------------
> =
> (Updated Nov. 30, 2011, 10:52 a.m.)
> =
> =
> Review request for Asterisk Developers, Paul Belanger and mjordan.
> =
> =
> Summary
> -------
> =
> A while back, Pabelanger and I were working on creating a general method =
of testing CDR logging. At the time, we sort of hit a wall with the order =
individual call logs were being stuffed into the master cdr file.
> =
> In order to alleviate that, this patch changes the CDRTestCase class to u=
se CDR files generated based on account codes. At the moment, I'm just spe=
cifically using a testsuite account code and loading that cdr file, but it =
isn't a stretch to say we could put in multiple account codes and use a bun=
ch of different cdr logs so that the order of which channel hangs up isn't =
important.
> =
> In addition to that, a couple minor changes were made to the cdr_originat=
e_sip_congestion_log test. It now runs without any chance for timing based=
failures (before it was 50/50 whether congestion or failure would come fir=
st/second, now only one action is checked and logged, that being the conges=
tion).
> =
> If this seems appropriate, I'll move forward with making the CDR Expectat=
ions use a variable to determine which file they should be checking against.
> =
> =
> Diffs
> -----
> =
> /asterisk/team/group/cdr_test_log_congestion/lib/python/asterisk/CDRTes=
tCase.py 2769 =
> =
> Diff: https://reviewboard.asterisk.org/r/1552/diff
> =
> =
> Testing
> -------
> =
> Checked to see how the test was logging CDR in separate files, made sure =
test was passing appropriately.
> =
> =
> Thanks,
> =
> jrose
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1552/">https://reviewboard.asterisk.org/r/1552/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good</pre> <br />
<p>- mjordan</p>
<br />
<p>On November 30th, 2011, 10:52 a.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Paul Belanger and mjordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2011, 10:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A while back, Pabelanger and I were working on creating a general method \
of testing CDR logging. At the time, we sort of hit a wall with the order individual \
call logs were being stuffed into the master cdr file.
In order to alleviate that, this patch changes the CDRTestCase class to use CDR files \
generated based on account codes. At the moment, I'm just specifically using a \
testsuite account code and loading that cdr file, but it isn't a stretch to say \
we could put in multiple account codes and use a bunch of different cdr logs so that \
the order of which channel hangs up isn't important.
In addition to that, a couple minor changes were made to the \
cdr_originate_sip_congestion_log test. It now runs without any chance for timing \
based failures (before it was 50/50 whether congestion or failure would come \
first/second, now only one action is checked and logged, that being the congestion).
If this seems appropriate, I'll move forward with making the CDR Expectations use \
a variable to determine which file they should be checking against.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked to see how the test was logging CDR in separate files, made sure \
test was passing appropriately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/group/cdr_test_log_congestion/lib/python/asterisk/CDRTestCase.py \
<span style="color: grey">(2769)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1552/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic