[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Separate verbose level for logging
From: "wdoekes" <reviewboard () asterisk ! org>
Date: 2011-11-29 16:34:27
Message-ID: 20111129163427.11141.54997 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1599/#review4884
-----------------------------------------------------------
Ship it!
I've ran out of things to nitpick about ;)
Ok, just one more:
/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1599/#comment9128>
Magic number in the source: s/5/__LOG_VERBOSE/
=
=
- wdoekes
On Nov. 29, 2011, 10:02 a.m., Tilghman Lesher wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1599/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2011, 10:02 a.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> One problem that many admins have today is that to have maximum verbosity=
going to the logs, for later debugging of trouble calls, the console becom=
es virtually unusable, because the verbosity level is global. This patch a=
ttempts to solve that problem, allowing each verbose recipient to have its =
own filter as to what it wants to receive.
> =
> =
> Diffs
> -----
> =
> /trunk/addons/chan_ooh323.c 346290 =
> /trunk/addons/res_config_mysql.c 346290 =
> /trunk/apps/app_rpt.c 346290 =
> /trunk/apps/app_verbose.c 346290 =
> /trunk/apps/app_voicemail.c 346290 =
> /trunk/channels/chan_sip.c 346290 =
> /trunk/channels/chan_skinny.c 346290 =
> /trunk/channels/chan_usbradio.c 346290 =
> /trunk/codecs/codec_dahdi.c 346290 =
> /trunk/configs/logger.conf.sample 346290 =
> /trunk/include/asterisk/logger.h 346290 =
> /trunk/main/asterisk.c 346290 =
> /trunk/main/bridging.c 346290 =
> /trunk/main/cli.c 346290 =
> /trunk/main/dial.c 346290 =
> /trunk/main/logger.c 346290 =
> /trunk/main/say.c 346290 =
> /trunk/res/res_clialiases.c 346290 =
> /trunk/res/res_fax.c 346290 =
> /trunk/res/res_jabber.c 346290 =
> /trunk/res/res_musiconhold.c 346290 =
> =
> Diff: https://reviewboard.asterisk.org/r/1599/diff
> =
> =
> Testing
> -------
> =
> Verified logging with files, consoles with different verbosity levels, et=
c.
> =
> =
> Thanks,
> =
> Tilghman
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1599/">https://reviewboard.asterisk.org/r/1599/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've ran out of \
things to nitpick about ;)
Ok, just one more:</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1599/diff/9/?file=22007#file22007line230" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/main/logger.c</a> <span style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">AST_THREADSTORAGE(verbose_buf);</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">230</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">res</span> <span class="o">|=</span> <span class="p">(</span><span \
class="mi">1</span> <span class="o"><<</span> <span class="mi">5</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Magic \
number in the source: s/5/__LOG_VERBOSE/
</pre>
</div>
<br />
<p>- wdoekes</p>
<br />
<p>On November 29th, 2011, 10:02 a.m., Tilghman Lesher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Tilghman Lesher.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2011, 10:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One problem that many admins have today is that to have maximum \
verbosity going to the logs, for later debugging of trouble calls, the console \
becomes virtually unusable, because the verbosity level is global. This patch \
attempts to solve that problem, allowing each verbose recipient to have its own \
filter as to what it wants to receive.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified logging with files, consoles with different verbosity levels, \
etc.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(346290)</span></li>
<li>/trunk/addons/res_config_mysql.c <span style="color: grey">(346290)</span></li>
<li>/trunk/apps/app_rpt.c <span style="color: grey">(346290)</span></li>
<li>/trunk/apps/app_verbose.c <span style="color: grey">(346290)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(346290)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(346290)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(346290)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(346290)</span></li>
<li>/trunk/codecs/codec_dahdi.c <span style="color: grey">(346290)</span></li>
<li>/trunk/configs/logger.conf.sample <span style="color: grey">(346290)</span></li>
<li>/trunk/include/asterisk/logger.h <span style="color: grey">(346290)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(346290)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(346290)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(346290)</span></li>
<li>/trunk/main/dial.c <span style="color: grey">(346290)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(346290)</span></li>
<li>/trunk/main/say.c <span style="color: grey">(346290)</span></li>
<li>/trunk/res/res_clialiases.c <span style="color: grey">(346290)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(346290)</span></li>
<li>/trunk/res/res_jabber.c <span style="color: grey">(346290)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(346290)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1599/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic