'Re: [asterisk-dev] [Code Review] Don't play a new song for every'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Don't play a new song for every
From:       "mjordan" <reviewboard () asterisk ! org>
Date:       2011-11-23 16:04:12
Message-ID: 20111123160412.21283.59015 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1596/#review4849
-----------------------------------------------------------

Ship it!

Looks good!

- mjordan

On Nov. 22, 2011, 7:38 p.m., Terry Wilson wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1596/
> -----------------------------------------------------------
> =

> (Updated Nov. 22, 2011, 7:38 p.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> As a result of the fix for ASTERISK-18039, realtime caching MOH no longer=
 properly resumes playing back a file between different holds in the same c=
all. This is because scanning for new files causes the existing file array =
to be emptied and we were just comparing that the saved pointer to the file=
name matched the pointer to the filename in a particular position in the ar=
ray. An easy fix is to save the filename instead of a pointer to it and the=
n do a strcmp instead of comparing the addresses.
> =

> =

> This addresses bug ASTERISK-18912.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18912
> =

> =

> Diffs
> -----
> =

>   /branches/1.8/res/res_musiconhold.c 346028 =

> =

> Diff: https://reviewboard.asterisk.org/r/1596/diff
> =

> =

> Testing
> -------
> =

> Tested adding and removing files from the moh directory and seeing that t=
hey were still picked up and that if we were playing a song and it still ex=
isted that we continued playing that song across multiple holds on the same=
 call.
> =

> =

> Thanks,
> =

> Terry
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1596/">https://reviewboard.asterisk.org/r/1596/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good!</pre>  <br \
/>

<p>- mjordan</p>

<br />
<p>On November 22nd, 2011, 7:38 p.m., Terry Wilson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>

<p style="color: grey;"><i>Updated Nov. 22, 2011, 7:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As a result of the fix for ASTERISK-18039, realtime caching MOH no \
longer properly resumes playing back a file between different holds in the same call. \
This is because scanning for new files causes the existing file array to be emptied \
and we were just comparing that the saved pointer to the filename matched the pointer \
to the filename in a particular position in the array. An easy fix is to save the \
filename instead of a pointer to it and then do a strcmp instead of comparing the \
addresses.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested adding and removing files from the moh directory and seeing that \
they were still picked up and that if we were playing a song and it still existed \
that we continued playing that song across multiple holds on the same call.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-18912">ASTERISK-18912</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/res/res_musiconhold.c <span style="color: \
grey">(346028)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1596/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 