'Re: [asterisk-dev] [Code Review]: Implement Externaddr on a sip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review]: Implement Externaddr on a sip
From:       "Olle E Johansson" <reviewboard () asterisk ! org>
Date:       2011-10-31 16:02:41
Message-ID: 20111031160241.2419.91975 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Oct. 31, 2011, 10:55 a.m., David Vossel wrote:
> > Is this peer extern ip cleared if it is taken out of the config?  Seems=
 like the option should be cleared in set_peer_defaults.  Maybe I missed wh=
ere that was being done.

Right. Fixed. Thanks for the feedback, David!

- Olle E

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1471/#review4613
-----------------------------------------------------------

On Sept. 29, 2011, 7:14 a.m., Olle E Johansson wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1471/
> -----------------------------------------------------------
> =

> (Updated Sept. 29, 2011, 7:14 a.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> Currently, the Asterisk SIP channel can only handle one externaddr per ho=
st. With this patch, every peer can have a externaddr setting so that we ca=
n have different externaddr for different SIP trunks.
> =

> =

> This addresses bug ASTERISK-18643.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18643
> =

> =

> Diffs
> -----
> =

>   /trunk/CHANGES 338415 =

>   /trunk/channels/chan_sip.c 338373 =

>   /trunk/channels/sip/include/sip.h 338373 =

>   /trunk/configs/sip.conf.sample 338373 =

> =

> Diff: https://reviewboard.asterisk.org/r/1471/diff
> =

> =

> Testing
> -------
> =

> The 1.4 version has been in production for about a year in a large call c=
enter.
> =

> =

> Thanks,
> =

> Olle E
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1471/">https://reviewboard.asterisk.org/r/1471/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 31st, 2011, 10:55 a.m., <b>David \
Vossel</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Is this peer extern ip cleared if it is taken out of the config?  Seems \
like the option should be cleared in set_peer_defaults.  Maybe I missed where that \
was being done.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right. Fixed. Thanks for \
the feedback, David! </pre>
<br />

<p>- Olle E</p>

<br />
<p>On September 29th, 2011, 7:14 a.m., Olle E Johansson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2011, 7:14 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the Asterisk SIP channel can only handle one externaddr per \
host. With this patch, every peer can have a externaddr setting so that we can have \
different externaddr for different SIP trunks.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The 1.4 version has been in production for about a year in a large call \
center.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-18643">ASTERISK-18643</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/CHANGES <span style="color: grey">(338415)</span></li>

 <li>/trunk/channels/chan_sip.c <span style="color: grey">(338373)</span></li>

 <li>/trunk/channels/sip/include/sip.h <span style="color: grey">(338373)</span></li>

 <li>/trunk/configs/sip.conf.sample <span style="color: grey">(338373)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1471/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 