'Re: [asterisk-dev] [Code Review] Dialplan function for manager'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Dialplan function for manager
From:       "Olle E Johansson" <reviewboard () asterisk ! org>
Date:       2011-10-31 15:32:48
Message-ID: 20111031153248.32749.38313 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/421/
-----------------------------------------------------------

(Updated Oct. 31, 2011, 10:32 a.m.)

Review request for Asterisk Developers.

Changes
-------

Updated to ao2_callback, finally :-)

Thanks Russell for all the examples!

Tested again, it works.

Summary
-------

Implementation of a dialplan function for checking manager accounts. I've m=
ade it extensible so that we can add other parameters when needed. Right no=
w it only checks the number of logged in sessions for a manager account.

Diffs (updated)
-----

  /trunk/main/manager.c 342755 =

Diff: https://reviewboard.asterisk.org/r/421/diff

Testing
-------

Tested on my Linux system and it reports manager logins properly - 0, 1 and=
 2 concurrent sessions...

Thanks,

Olle E

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/421/">https://reviewboard.asterisk.org/r/421/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2011, 10:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated to ao2_callback, finally :-)

Thanks Russell for all the examples!

Tested again, it works.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implementation of a dialplan function for checking manager accounts. \
I&#39;ve made it extensible so that we can add other parameters when needed. Right \
now it only checks the number of logged in sessions for a manager account.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on my Linux system and it reports manager logins properly - 0, 1 \
and 2 concurrent sessions...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/main/manager.c <span style="color: grey">(342755)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/421/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 