[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: [asterisk-dev] [Code Review] "r" dial params stop give ringback if
From: "opticron" <reviewboard () asterisk ! org>
Date: 2011-08-29 19:40:19
Message-ID: 20110829194019.9418.13184 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1398/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
When a single channel is dialed and there is media to be forwarded to the c=
alling channel, the media is written without regard for ringback causing si=
lence to be heard in some circumstances. This regression was introduced wh=
en the meaning of "single" changed to mean only the number of channels dial=
ed.
This addresses bug ASTERISK-18083.
https://issues.asterisk.org/jira/browse/ASTERISK-18083
Diffs
-----
trunk/apps/app_dial.c 333475 =
Diff: https://reviewboard.asterisk.org/r/1398/diff
Testing
-------
Verified that the behavior of multiple dialed channels with these options r=
emained unchanged while the behavior of a single dialed channel that attemp=
ted to send media was corrected when ringback was requested.
Thanks,
opticron
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1398/">https://reviewboard.asterisk.org/r/1398/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a single channel is dialed and there is media to be forwarded to \
the calling channel, the media is written without regard for ringback causing silence \
to be heard in some circumstances. This regression was introduced when the meaning \
of "single" changed to mean only the number of channels dialed.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that the behavior of multiple dialed channels with these \
options remained unchanged while the behavior of a single dialed channel that \
attempted to send media was corrected when ringback was requested.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18083">ASTERISK-18083</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/apps/app_dial.c <span style="color: grey">(333475)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1398/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic