'[asterisk-dev] [Code Review] SIP Notify via AMI or CLI leaks SIP'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] SIP Notify via AMI or CLI leaks SIP
From:       "opticron" <reviewboard () asterisk ! org>
Date:       2011-07-28 18:15:58
Message-ID: 20110728181558.710.15244 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1332/
-----------------------------------------------------------

Review request for Asterisk Developers.

Summary
-------

Any SIP notify sent via AMI or CLI leaks a SIP PVT with ref count +2.  This=
 seems to have occurred when or before transmit_sip_request was replaced by=
 other functions.  Removing the additional ref just before the invite and a=
dding an unref following it corrects the issue as seen via REF_DEBUG.  The =
unref existed in a distant revision and it appears as though the wrong ref =
operation was removed.

This addresses bug ASTERISK-18091.
    https://issues.asterisk.org/jira/browse/ASTERISK-18091

Diffs
-----

  trunk/channels/chan_sip.c 329610 =

Diff: https://reviewboard.asterisk.org/r/1332/diff

Testing
-------

Reproduced the leak and made sure the leak no longer occurred with the chan=
ge.

Thanks,

opticron

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1332/">https://reviewboard.asterisk.org/r/1332/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Any SIP notify sent via AMI or CLI leaks a SIP PVT with ref count +2.  \
This seems to have occurred when or before transmit_sip_request was replaced by other \
functions.  Removing the additional ref just before the invite and adding an unref \
following it corrects the issue as seen via REF_DEBUG.  The unref existed in a \
distant revision and it appears as though the wrong ref operation was removed.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reproduced the leak and made sure the leak no longer occurred with the \
change.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-18091">ASTERISK-18091</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/channels/chan_sip.c <span style="color: grey">(329610)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1332/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 