[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Prepend voicemail timeout bug
From: "jrose" <reviewboard () asterisk ! org>
Date: 2011-07-25 21:05:49
Message-ID: 20110725210549.32114.91925 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 25, 2011, 12:29 p.m., David Vossel wrote:
> > /branches/1.8/main/app.c, lines 726-729
> > <https://reviewboard.asterisk.org/r/1327/diff/2/?file=17598#file17598line726>
> >
> > There is no documentation for skip_confirmation_sound argument here.
My bad. Addressed.
> On July 25, 2011, 12:29 p.m., David Vossel wrote:
> > /branches/1.8/apps/app_voicemail.c, lines 864-866
> > <https://reviewboard.asterisk.org/r/1327/diff/2/?file=17595#file17595line864>
> >
> > What would you suggest this being other than "then press pound" ? it might be \
> > worth documenting that here for the future.
If we ultimately want to leave the behavior as is, I suggest something along the \
lines of "Recording timed out. Please try again and push any button when finished"
We have a few options though as to changing how it functions. We could simply accept \
the pound key, in which case we could mess with the existing Allison VM prompt of \
"try again" and "When done, hang up or press the pound key" to just "Try again. When \
done, press the pound key"
There are a couple other approaches though, like an after-the-prepend menu where we \
could ask the user if they want to accept the recording as is or not. That would \
require more voice work and also would be a bigger change to the code, so I think the \
former is more ideal.
I will go ahead and add this documentation though.
> On July 25, 2011, 12:29 p.m., David Vossel wrote:
> > /branches/1.8/configs/voicemail.conf.sample, lines 321-325
> > <https://reviewboard.asterisk.org/r/1327/diff/2/?file=17596#file17596line321>
> >
> > Since we have a default sound we are using, we should document it. "Then press \
> > pound"
Alrighty, documenting that as suggested.
- jrose
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1327/#review3926
-----------------------------------------------------------
On July 21, 2011, 3:02 p.m., jrose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1327/
> -----------------------------------------------------------
>
> (Updated July 21, 2011, 3:02 p.m.)
>
>
> Review request for Asterisk Developers, David Vossel and mjordan.
>
>
> Summary
> -------
>
> When recording a prepend message for voicemail, I think the following is the \
> intended behavior:
> 1. User starts prepend recording
> 2. User concludes prepend recording with a button in order to finish the \
> recording. Confirm success if the user stops the recording manually. 3. If the \
> user times out instead, confirm a failure and go back to the menu with no changes.
> What was happening instead was...
>
> The first time through, things were mostly as above, except if the user timed out, \
> Allison would use the same message as if the call went through. The recording would \
> not be made in this instance.
> However, the second time and above through, a flag saying the call had already been \
> recorded would be raised and this would trigger some file copying events on files \
> that shouldn't have been being copied. If the call timed out again, the prepend \
> message would write over the inbox message and the whole message would be forwarded \
> to the recipient.
> This patch changes Allison's prompt for timing out while in voicemail mode when not \
> entering the finished recording mode to say "Sorry, Please Try again" followed by \
> "Press the pound key when finished" (I might be paraphrasing slightly). \
> Technically any DTMF works, but I haven't seen any prompt for that yet and I \
> haven't settled on this as a permanent solution. After this point, when the menu \
> comes back around, we lower the flag for the recording having been made essentially \
> reverting back to the original state of the menu.
> If this seems appropriate but less than ideal, I am ready at to begin adding a \
> post-prepend-recording menu that will allow the user to review the complete message \
> as well as accept, re-record it, append it, cancel it, etc. before sending it on. \
> Naturally if something like this were in place, there wouldn't be any need to just \
> outright discard prepend recordings after a time-out. Depending on how many of \
> those options we want to include, that could be some extra voice work, so we might \
> consider holding off on that for now and just going with the patch as is, since \
> this works and it informs the user of what is happening much more clearly than the \
> current means does.
> This is actually the second revision of the patch and moves the speech into \
> app_voicemail's forwarding menu code and prepares it for customization. Speech \
> file customization isn't tested yet, but looks right.
>
> Diffs
> -----
>
> /branches/1.8/apps/app_voicemail.c 329012
> /branches/1.8/configs/voicemail.conf.sample 329012
> /branches/1.8/include/asterisk/app.h 329012
> /branches/1.8/main/app.c 329012
>
> Diff: https://reviewboard.asterisk.org/r/1327/diff
>
>
> Testing
> -------
>
> Tested prepend with timeout and prepend with confirmation, as well as multiple \
> timeouts and multiple timeouts followed by recording with confirmation. In each \
> case there is no residual backup message, and the call is processed as expected. \
> Also, the prepend message no longer gets tacked onto the original message.
>
> Thanks,
>
> jrose
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1327/">https://reviewboard.asterisk.org/r/1327/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 25th, 2011, 12:29 p.m., <b>David \
Vossel</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1327/diff/2/?file=17595#file17595line864" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/1.8/apps/app_voicemail.c</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
char vm_invalid_password[80] = "vm-invalid-password";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">864</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> \
<span class="kt">char</span> <span class="n">vm_pls_try_again</span><span \
class="p">[</span><span class="mi">80</span><span class="p">]</span> <span \
class="o">=</span> <span class="s">"vm-pls-try-again"</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">864</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span \
class="kt">char</span> <span class="n">vm_pls_try_again</span><span \
class="p">[</span><span class="mi">80</span><span class="p">]</span> <span \
class="o">=</span> <span class="s">"vm-pls-try-again"</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">865</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">static</span> <span class="kt">char</span> <span \
class="n">vm_prepend_timeout</span><span class="p">[</span><span \
class="mi">80</span><span class="p">]</span> <span class="o">=</span> <span \
class="s">"then-press-pound"</span><span class="p">;</span> <span \
class="cm">/* Should be substituted for something more appropriate \
*/</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">865</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">866</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What would you suggest \
this being other than "then press pound" ? it might be worth documenting \
that here for the future.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we \
ultimately want to leave the behavior as is, I suggest something along the lines of \
"Recording timed out. Please try again and push any button when finished"
We have a few options though as to changing how it functions. We could simply accept \
the pound key, in which case we could mess with the existing Allison VM prompt of \
"try again" and "When done, hang up or press the pound key" to \
just "Try again. When done, press the pound key"
There are a couple other approaches though, like an after-the-prepend menu where we \
could ask the user if they want to accept the recording as is or not. That would \
require more voice work and also would be a bigger change to the code, so I think the \
former is more ideal.
I will go ahead and add this documentation though.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 25th, 2011, 12:29 p.m., <b>David \
Vossel</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1327/diff/2/?file=17596#file17596line321" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/1.8/configs/voicemail.conf.sample</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">321</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">; \
vm-prepend-timeout=custom_sound</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">322</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
; Customize which sound file is used when the user</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">323</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
; times out while recording a prepend message instead</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">324</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
; of the default prompt that says: ...</pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">321</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">; \
listen-control-forward-key=# ; Customize the key that fast-forwards message \
playback</pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">325</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">; listen-control-forward-key=# ; Customize the key that fast-forwards message \
playback</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we have a default \
sound we are using, we should document it. "Then press pound"</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alrighty, \
documenting that as suggested.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 25th, 2011, 12:29 p.m., <b>David \
Vossel</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1327/diff/2/?file=17598#file17598line726" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/1.8/main/app.c</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
int global_silence_threshold = 128;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">726</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \param \
acceptdtmf DTMF digits that will end the recording.</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">726</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param acceptdtmf DTMF digits that will end the \
recording.</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">727</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \param \
canceldtmf DTMF digits that will cancel the recording.</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">727</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param canceldtmf DTMF digits that will cancel the \
recording.</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">728</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> *</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">729</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \retval -1 failure or hangup</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no \
documentation for skip_confirmation_sound argument here.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My bad. \
Addressed.</pre> <br />
<p>- jrose</p>
<br />
<p>On July 21st, 2011, 3:02 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, David Vossel and mjordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 21, 2011, 3:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When recording a prepend message for voicemail, I think the following is \
the intended behavior:
1. User starts prepend recording
2. User concludes prepend recording with a button in order to finish the recording. \
Confirm success if the user stops the recording manually. 3. If the user times out \
instead, confirm a failure and go back to the menu with no changes.
What was happening instead was...
The first time through, things were mostly as above, except if the user timed out, \
Allison would use the same message as if the call went through. The recording would \
not be made in this instance.
However, the second time and above through, a flag saying the call had already been \
recorded would be raised and this would trigger some file copying events on files \
that shouldn't have been being copied. If the call timed out again, the prepend \
message would write over the inbox message and the whole message would be forwarded \
to the recipient.
This patch changes Allison's prompt for timing out while in voicemail mode when \
not entering the finished recording mode to say "Sorry, Please Try again" \
followed by "Press the pound key when finished" (I might be paraphrasing \
slightly). Technically any DTMF works, but I haven't seen any prompt for that \
yet and I haven't settled on this as a permanent solution. After this point, \
when the menu comes back around, we lower the flag for the recording having been made \
essentially reverting back to the original state of the menu.
If this seems appropriate but less than ideal, I am ready at to begin adding a \
post-prepend-recording menu that will allow the user to review the complete message \
as well as accept, re-record it, append it, cancel it, etc. before sending it on. \
Naturally if something like this were in place, there wouldn't be any need to \
just outright discard prepend recordings after a time-out. Depending on how many of \
those options we want to include, that could be some extra voice work, so we might \
consider holding off on that for now and just going with the patch as is, since this \
works and it informs the user of what is happening much more clearly than the current \
means does.
This is actually the second revision of the patch and moves the speech into \
app_voicemail's forwarding menu code and prepares it for customization. Speech \
file customization isn't tested yet, but looks right.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested prepend with timeout and prepend with confirmation, as well as \
multiple timeouts and multiple timeouts followed by recording with confirmation. In \
each case there is no residual backup message, and the call is processed as expected. \
Also, the prepend message no longer gets tacked onto the original message.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_voicemail.c <span style="color: \
grey">(329012)</span></li>
<li>/branches/1.8/configs/voicemail.conf.sample <span style="color: \
grey">(329012)</span></li>
<li>/branches/1.8/include/asterisk/app.h <span style="color: \
grey">(329012)</span></li>
<li>/branches/1.8/main/app.c <span style="color: grey">(329012)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1327/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic