[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Fixup deadlock in chan_sip
From: "irroot" <reviewboard () asterisk ! org>
Date: 2011-07-25 17:37:55
Message-ID: 20110725173755.12155.27201 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 25, 2011, 12:32 p.m., David Vossel wrote:
> > I have a patch on an issue right now that may address this problem. Check out \
> > the latest patch I uploaded here. \
> > https://issues.asterisk.org/jira/browse/ASTERISK-18082
Thx yeah 18082 should be the ticket i did this based on a report by micc_ on IRC \
please and link to this RB/Bug when closing
- irroot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1322/#review3929
-----------------------------------------------------------
On July 25, 2011, 11:36 a.m., irroot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1322/
> -----------------------------------------------------------
>
> (Updated July 25, 2011, 11:36 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> =======================================================================
> === Currently Held Locks ==============================================
> =======================================================================
> ===
> === <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock \
> addr> (times locked) ===
> === Thread ID: 0xb6e91b90 (do_monitor started at [25036] chan_sip.c \
> restart_monitor()) === ---> Lock #0 (chan_sip.c): MUTEX 24551 handle_request_do \
> &netlock 0x1d3f80 (1) === ---> Lock #1 (chan_sip.c): MUTEX 22802 \
> handle_request_refer p 0x9fe9170 (1) === ---> Lock #2 (channel.c): MUTEX 6300 \
> ast_do_masquerade channels 0x9c0daf8 (1) === ---> Tried and failed to get Lock #3 \
> (channel.c): MUTEX 6323 ast_do_masquerade clonechan 0xb6e1978 (0) === \
> ------------------------------------------------------------------- ===
> === Thread ID: 0x1e4cb90 (pbx_thread started at [ 5079] pbx.c \
> ast_pbx_start()) === ---> Lock #0 (channel.c): MUTEX 4749 ast_write chan 0xad3ba860 \
> (1) === -------------------------------------------------------------------
> ===
> === Thread ID: 0x54a0b90 (pbx_thread started at [ 5079] pbx.c \
> ast_pbx_start()) === ---> Lock #0 (channel.c): MUTEX 3714 __ast_read chan 0xb6e1978 \
> (1) === ---> Waiting for Lock #1 (chan_sip.c): MUTEX 7234 sip_read p 0x9fe9170 (1)
> === --- ---> Locked Here: chan_sip.c line 22802 (handle_request_refer)
> === -------------------------------------------------------------------
> ===
> =======================================================================
>
>
> This addresses bug ASTERISK-18149.
> https://issues.asterisk.org/jira/browse/ASTERISK-18149
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 329432
>
> Diff: https://reviewboard.asterisk.org/r/1322/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> irroot
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1322/">https://reviewboard.asterisk.org/r/1322/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 25th, 2011, 12:32 p.m., <b>David \
Vossel</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have a patch on an issue right now that may address this problem. \
Check out the latest patch I uploaded here. \
https://issues.asterisk.org/jira/browse/ASTERISK-18082</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thx yeah 18082 should be \
the ticket i did this based on a report by micc_ on IRC please and link to this \
RB/Bug when closing</pre> <br />
<p>- irroot</p>
<br />
<p>On July 25th, 2011, 11:36 a.m., irroot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By irroot.</div>
<p style="color: grey;"><i>Updated July 25, 2011, 11:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">======================================================================= \
=== Currently Held Locks ============================================== \
======================================================================= ===
=== <pending> <lock#> (<file>): <lock type> <line num> \
<function> <lock name> <lock addr> (times locked) ===
=== Thread ID: 0xb6e91b90 (do_monitor started at [25036] chan_sip.c \
restart_monitor()) === ---> Lock #0 (chan_sip.c): MUTEX 24551 handle_request_do \
&netlock 0x1d3f80 (1) === ---> Lock #1 (chan_sip.c): MUTEX 22802 \
handle_request_refer p 0x9fe9170 (1) === ---> Lock #2 (channel.c): MUTEX 6300 \
ast_do_masquerade channels 0x9c0daf8 (1) === ---> Tried and failed to get Lock #3 \
(channel.c): MUTEX 6323 ast_do_masquerade clonechan 0xb6e1978 (0) === \
------------------------------------------------------------------- ===
=== Thread ID: 0x1e4cb90 (pbx_thread started at [ 5079] pbx.c \
ast_pbx_start()) === ---> Lock #0 (channel.c): MUTEX 4749 ast_write chan \
0xad3ba860 (1) === -------------------------------------------------------------------
===
=== Thread ID: 0x54a0b90 (pbx_thread started at [ 5079] pbx.c \
ast_pbx_start()) === ---> Lock #0 (channel.c): MUTEX 3714 __ast_read chan \
0xb6e1978 (1) === ---> Waiting for Lock #1 (chan_sip.c): MUTEX 7234 sip_read p \
0x9fe9170 (1) === --- ---> Locked Here: chan_sip.c line 22802 \
(handle_request_refer) === \
------------------------------------------------------------------- ===
=======================================================================</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18149">ASTERISK-18149</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(329432)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1322/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic