'Re: [asterisk-dev] [Code Review] Confbridge single source video'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Confbridge single source video
From:       "David Vossel" <reviewboard () asterisk ! org>
Date:       2011-06-30 18:46:44
Message-ID: 20110630184644.5420.71362 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1288/
-----------------------------------------------------------

(Updated 2011-06-30 13:46:44.006603)

Review request for Asterisk Developers.

Changes
-------

Follow the talker video support.

Summary
-------

This patch gives Confbridge the ability to distribute a single video feed t=
o all participants in the bridge.  Right now this is done by allowing marke=
d users capable of video to join and distribute their video feed to all the=
 users of the conference.  There are two strategies enabled for conferences=
 where there are multiple marked users present and capable of video.  These=
 strategies are part of the new video_mode option added to the bridge profi=
le.  For more information, refer to the documentation in confbridge.conf

Diffs (updated)
-----

  /trunk/apps/app_confbridge.c 325818 =

  /trunk/apps/confbridge/conf_config_parser.c 325818 =

  /trunk/apps/confbridge/include/confbridge.h 325818 =

  /trunk/bridges/bridge_softmix.c 325818 =

  /trunk/configs/confbridge.conf.sample 325818 =

  /trunk/include/asterisk/bridging.h 325818 =

  /trunk/include/asterisk/dsp.h 325818 =

  /trunk/main/bridging.c 325818 =

  /trunk/main/dsp.c 325818 =

Diff: https://reviewboard.asterisk.org/r/1288/diff

Testing
-------

I tested this with multiple linphone clients and audio only clients.

Thanks,

David

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1288/">https://reviewboard.asterisk.org/r/1288/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By David Vossel.</div>

<p style="color: grey;"><i>Updated 2011-06-30 13:46:44.006603</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Follow the talker video support.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch gives Confbridge the ability to distribute a single video \
feed to all participants in the bridge.  Right now this is done by allowing marked \
users capable of video to join and distribute their video feed to all the users of \
the conference.  There are two strategies enabled for conferences where there are \
multiple marked users present and capable of video.  These strategies are part of the \
new video_mode option added to the bridge profile.  For more information, refer to \
the documentation in confbridge.conf</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested this with multiple linphone clients and audio only \
clients.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/apps/app_confbridge.c <span style="color: grey">(325818)</span></li>

 <li>/trunk/apps/confbridge/conf_config_parser.c <span style="color: \
grey">(325818)</span></li>

 <li>/trunk/apps/confbridge/include/confbridge.h <span style="color: \
grey">(325818)</span></li>

 <li>/trunk/bridges/bridge_softmix.c <span style="color: grey">(325818)</span></li>

 <li>/trunk/configs/confbridge.conf.sample <span style="color: \
grey">(325818)</span></li>

 <li>/trunk/include/asterisk/bridging.h <span style="color: \
grey">(325818)</span></li>

 <li>/trunk/include/asterisk/dsp.h <span style="color: grey">(325818)</span></li>

 <li>/trunk/main/bridging.c <span style="color: grey">(325818)</span></li>

 <li>/trunk/main/dsp.c <span style="color: grey">(325818)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1288/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 