'Re: [asterisk-dev] [Code Review] Response to QueueRule manager'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Response to QueueRule manager
From:       "rmudgett" <reviewboard () asterisk ! org>
Date:       2011-06-29 16:27:50
Message-ID: 20110629162750.11549.50180 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2011-06-29 10:16:30, Russell Bryant wrote:
> > Looks good.  It looks like you removed docs though, is that intentional?

Yes.  The removal reason is documented in the review board patch descriptio=
n about the ActionID with the Queues AMI action.

- rmudgett

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1295/#review3784
-----------------------------------------------------------

On 2011-06-27 15:00:34, rmudgett wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1295/
> -----------------------------------------------------------
> =

> (Updated 2011-06-27 15:00:34)
> =

> =

> Review request for Asterisk Developers and Russell Bryant.
> =

> =

> Summary
> -------
> =

> Add ActionID support as documented for the QueueRule AMI action.
> =

> Also remove documentation for ActionID with the Queues AMI action.  The o=
utput does not follow normal AMI response output and there is no place to p=
ut an ActionID header.
> =

> This is a short patch that I am mainly interested in comments about the d=
irection of resolution.
> =

> =

> Diffs
> -----
> =

>   /branches/1.8/apps/app_queue.c 325025 =

> =

> Diff: https://reviewboard.asterisk.org/r/1295/diff
> =

> =

> Testing
> -------
> =

> The Response and ActionID headers are output for the QueueRule AMI action.
> =

> =

> Thanks,
> =

> rmudgett
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1295/">https://reviewboard.asterisk.org/r/1295/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 29th, 2011, 10:16 a.m., <b>Russell \
Bryant</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good.  It looks like you removed docs though, is that \
intentional?</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.  The removal reason \
is documented in the review board patch description about the ActionID with the \
Queues AMI action.</pre> <br />

<p>- rmudgett</p>

<br />
<p>On June 27th, 2011, 3 p.m., rmudgett wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By rmudgett.</div>

<p style="color: grey;"><i>Updated 2011-06-27 15:00:34</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add ActionID support as documented for the QueueRule AMI action.

Also remove documentation for ActionID with the Queues AMI action.  The output does \
not follow normal AMI response output and there is no place to put an ActionID \
header.

This is a short patch that I am mainly interested in comments about the direction of \
resolution.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Response and ActionID headers are output for the QueueRule AMI \
action.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/apps/app_queue.c <span style="color: grey">(325025)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1295/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 