[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Add ConnectedLineNum and
From: "Russell Bryant" <reviewboard () asterisk ! org>
Date: 2011-05-25 15:39:01
Message-ID: 20110525153901.1877.29236 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1227/#review3617
-----------------------------------------------------------
Ship it!
- Russell
On 2011-05-23 15:29:58, rmudgett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1227/
> -----------------------------------------------------------
>
> (Updated 2011-05-23 15:29:58)
>
>
> Review request for Asterisk Developers and Russell Bryant.
>
>
> Summary
> -------
>
> The ConnectedLineNum and ConnectedLineName headers were added to many AMI
> events/responses if the CallerIDNum/CallerIDName headers were also present.
>
> The addition of connected line support changes the behavior of the channel
> caller ID somewhat. The channel caller ID value no longer time shares with
> the connected line ID on outgoing call legs. The timing of some AMI
> events/responses output the connected line ID as caller ID. These party ID's
> are now separate.
>
>
> This addresses bug 18252.
> https://issues.asterisk.org/view.php?id=18252
>
>
> Diffs
> -----
>
> /branches/1.8/CHANGES 320708
> /branches/1.8/UPGRADE.txt 320708
> /branches/1.8/apps/app_dial.c 320708
> /branches/1.8/apps/app_fax.c 320708
> /branches/1.8/apps/app_meetme.c 320708
> /branches/1.8/apps/app_queue.c 320708
> /branches/1.8/main/channel.c 320708
> /branches/1.8/main/features.c 320708
> /branches/1.8/main/manager.c 320708
>
> Diff: https://reviewboard.asterisk.org/r/1227/diff
>
>
> Testing
> -------
>
> Compile testing and code inspection at this point.
>
>
> Thanks,
>
> rmudgett
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1227/">https://reviewboard.asterisk.org/r/1227/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Russell</p>
<br />
<p>On May 23rd, 2011, 3:29 p.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated 2011-05-23 15:29:58</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The ConnectedLineNum and ConnectedLineName headers were added to many \
AMI events/responses if the CallerIDNum/CallerIDName headers were also present.
The addition of connected line support changes the behavior of the channel
caller ID somewhat. The channel caller ID value no longer time shares with
the connected line ID on outgoing call legs. The timing of some AMI
events/responses output the connected line ID as caller ID. These party ID's
are now separate.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compile testing and code inspection at this point.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=18252">18252</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/CHANGES <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/UPGRADE.txt <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/apps/app_dial.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/apps/app_fax.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/apps/app_meetme.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/apps/app_queue.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/main/channel.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/main/features.c <span style="color: grey">(320708)</span></li>
<li>/branches/1.8/main/manager.c <span style="color: grey">(320708)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1227/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic