[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Fax Gateway Implementation
From: "irroot" <reviewboard () asterisk ! org>
Date: 2011-04-30 17:47:29
Message-ID: 20110430174729.723.23785 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3455
-----------------------------------------------------------
/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/1116/#comment7108>
Hi can someone help me out here i cant see a way of putting this into a framehook \
on one channel ...
the problem is these control frames are "eaten" by the bridge this precludes them \
from been used in a framehook ...
i either have to leave this hook or run a framehook on both channels in the \
bridge...
Thx
- irroot
On 2011-04-30 11:43:33, irroot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
>
> (Updated 2011-04-30 11:43:33)
>
>
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, \
> Leif Madsen, and dafe_von_cetin.
>
> Summary
> -------
>
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 \
> app_fax has been moved to trunk [1.10] ive made some cleanups and moved it into \
> res_fax res_fax_spandsp this is the framework and not production code unfortunately \
> i have no means of testing it at the moment and require help.
> i have cleaned the code up substantially it is related to R459
>
> hope this is found useful and aids in the goal to get it in 1.10.
>
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
>
>
> This addresses bug 13405.
> https://issues.asterisk.org/view.php?id=13405
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 316037
> /trunk/apps/app_faxdetect.c PRE-CREATION
> /trunk/channels/sip/include/sip.h 316037
> /trunk/configs/sip.conf.sample 316037
> /trunk/include/asterisk/channel.h 316037
> /trunk/include/asterisk/res_fax.h 316037
> /trunk/main/channel.c 316037
> /trunk/res/res_fax.c 316037
> /trunk/res/res_fax_spandsp.c 316037
>
> Diff: https://reviewboard.asterisk.org/r/1116/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> irroot
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1116/">https://reviewboard.asterisk.org/r/1116/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1116/diff/9/?file=16297#file16297line1614" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/include/asterisk/channel.h</a> <span style="font-weight: \
normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
ast_indicate(struct ast_channel *chan, int condition);</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1614</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \brief Manage AST_CONTROL_T38_PARAMETERS when T38 Gateway is \
required</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1615</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param chan</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1616</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param peer</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1617</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param active</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1618</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * \param f</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1619</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Function is provided by res_fax.so</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1620</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> */</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1621</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">extern</span> <span class="kt">int</span> <span class="p">(</span><span \
class="o">*</span><span class="n">ast_t38_gateway_handle_parameters</span><span \
class="p">)(</span><span class="k">struct</span> <span class="n">ast_channel</span> \
<span class="o">*</span><span class="n">chan</span><span class="p">,</span><span \
class="k">struct</span> <span class="n">ast_channel</span> <span \
class="o">*</span><span class="n">peer</span><span class="p">,</span><span \
class="k">struct</span> <span class="n">ast_channel</span> <span \
class="o">*</span><span class="n">active</span><span class="p">,</span> <span \
class="k">struct</span> <span class="n">ast_frame</span> <span \
class="o">*</span><span class="n">f</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi can \
someone help me out here i cant see a way of putting this into a framehook on one \
channel ...
the problem is these control frames are "eaten" by the bridge this \
precludes them from been used in a framehook ...
i either have to leave this hook or run a framehook on both channels in the bridge...
Thx</pre>
</div>
<br />
<p>- irroot</p>
<br />
<p>On April 30th, 2011, 11:43 a.m., irroot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, \
dimas, Leif Madsen, and dafe_von_cetin.</div> <div>By irroot.</div>
<p style="color: grey;"><i>Updated 2011-04-30 11:43:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi there the patch that was going around circa 2008 to implement this in \
1.4/1.6 app_fax has been moved to trunk [1.10] ive made some cleanups and moved it \
into res_fax res_fax_spandsp this is the framework and not production code \
unfortunately i have no means of testing it at the moment and require help.
i have cleaned the code up substantially it is related to R459
hope this is found useful and aids in the goal to get it in 1.10.
Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=13405">13405</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(316037)</span></li>
<li>/trunk/apps/app_faxdetect.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(316037)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(316037)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(316037)</span></li>
<li>/trunk/include/asterisk/res_fax.h <span style="color: grey">(316037)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(316037)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(316037)</span></li>
<li>/trunk/res/res_fax_spandsp.c <span style="color: grey">(316037)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1116/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic