'Re: [asterisk-dev] [Code Review] Changes to h323 to allow use with'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Changes to h323 to allow use with
From:       "irroot" <reviewboard () asterisk ! org>
Date:       2011-04-27 15:53:06
Message-ID: 20110427155306.31854.89853 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1117/
-----------------------------------------------------------

(Updated 2011-04-27 10:53:06.784628)

Review request for Asterisk Developers.

Changes
-------

Applied additional formating.

Summary
-------

Changes to h323 to allow use with h323plus > 1.20.

This addresses bugs 16619 and 18670.
    https://issues.asterisk.org/view.php?id=16619
    https://issues.asterisk.org/view.php?id=18670

Diffs (updated)
-----

  /trunk/channels/chan_h323.c 315724 
  /trunk/channels/h323/ast_h323.h 315724 
  /trunk/channels/h323/ast_h323.cxx 315724 
  /trunk/channels/h323/chan_h323.h 315724 
  /trunk/configs/h323.conf.sample 315724 
  /trunk/configure.ac 315724 

Diff: https://reviewboard.asterisk.org/r/1117/diff

Testing
-------

Thanks,

irroot

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1117/">https://reviewboard.asterisk.org/r/1117/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By irroot.</div>

<p style="color: grey;"><i>Updated 2011-04-27 10:53:06.784628</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applied additional formating.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes to h323 to allow use with h323plus &gt; 1.20.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/view.php?id=16619">16619</a>, 

 <a href="https://issues.asterisk.org/view.php?id=18670">18670</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/channels/chan_h323.c <span style="color: grey">(315724)</span></li>

 <li>/trunk/channels/h323/ast_h323.h <span style="color: grey">(315724)</span></li>

 <li>/trunk/channels/h323/ast_h323.cxx <span style="color: grey">(315724)</span></li>

 <li>/trunk/channels/h323/chan_h323.h <span style="color: grey">(315724)</span></li>

 <li>/trunk/configs/h323.conf.sample <span style="color: grey">(315724)</span></li>

 <li>/trunk/configure.ac <span style="color: grey">(315724)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1117/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 