[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] memcached utilities for asterisk
From: "Brad Latus" <reviewboard () asterisk ! org>
Date: 2011-03-29 19:05:22
Message-ID: 20110329190522.21880.18879 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1139/#review3263
-----------------------------------------------------------
I would follow oej's view, it should be more like the DB functions since th=
ey do the same.
Also throughout the code your not following some of the CODING-GUIDELINES.t=
xt
Main thing I noticed was that you declare variables all around the code, al=
l variables must be declared at top of scope. =
You also have no message/default if people happen to specify an invalid or =
wrong hash function (at my quick look)
- Brad
On 2011-03-15 11:56:21, drivefast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1139/
> -----------------------------------------------------------
> =
> (Updated 2011-03-15 11:56:21)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> memcached utilities for asterisk dialplans
> =
> =
> Diffs
> -----
> =
> /trunk/build_tools/menuselect-deps.in 310878 =
> /trunk/configs/memcached.conf.sample PRE-CREATION =
> /trunk/configure.ac 310878 =
> /trunk/makeopts.in 310878 =
> /trunk/res/res_memcached.c PRE-CREATION =
> =
> Diff: https://reviewboard.asterisk.org/r/1139/diff
> =
> =
> Testing
> -------
> =
> dialplan that touches all the functions and apps
> =
> =
> Thanks,
> =
> drivefast
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1139/">https://reviewboard.asterisk.org/r/1139/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would follow oej's \
view, it should be more like the DB functions since they do the same. Also throughout \
the code your not following some of the CODING-GUIDELINES.txt Main thing I noticed \
was that you declare variables all around the code, all variables must be declared at \
top of scope. You also have no message/default if people happen to specify an \
invalid or wrong hash function (at my quick look)</pre> <br />
<p>- Brad</p>
<br />
<p>On March 15th, 2011, 11:56 a.m., drivefast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By drivefast.</div>
<p style="color: grey;"><i>Updated 2011-03-15 11:56:21</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">memcached utilities for asterisk dialplans</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">dialplan that touches all the functions and apps</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/build_tools/menuselect-deps.in <span style="color: \
grey">(310878)</span></li>
<li>/trunk/configs/memcached.conf.sample <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(310878)</span></li>
<li>/trunk/makeopts.in <span style="color: grey">(310878)</span></li>
<li>/trunk/res/res_memcached.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1139/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic