[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] FeatureDetected AMI event
From:       "Olle E Johansson" <reviewboard () asterisk ! org>
Date:       2010-12-22 20:57:38
Message-ID: 20101222205738.19394.5731 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1065/#review3064
-----------------------------------------------------------


Be careful with the word "Peer". People expect it to be something else. We =
have many examples of secondary channels, try to get inspiration from them.

Also, this has to be configurable. In some configurations, this event might=
 overload an app. Maybe even per event.

Otherwise, a nice idea. =


- Olle E


On 2010-12-22 13:21:53, Paul Belanger wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1065/
> -----------------------------------------------------------
> =

> (Updated 2010-12-22 13:21:53)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> A simple patch to detect when a DTMF feature from the AMI. Feedback on th=
e event name is requested :)
> =

> =

> Diffs
> -----
> =

>   trunk/CHANGES 299001 =

>   trunk/main/features.c 299001 =

> =

> Diff: https://reviewboard.asterisk.org/r/1065/diff
> =

> =

> Testing
> -------
> =

> Local dev box.
> =

> =

> Thanks,
> =

> Paul
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1065/">https://reviewboard.asterisk.org/r/1065/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Be careful with the word \
&quot;Peer&quot;. People expect it to be something else. We have many examples of \
secondary channels, try to get inspiration from them.

Also, this has to be configurable. In some configurations, this event might overload \
an app. Maybe even per event.

Otherwise, a nice idea. </pre>
 <br />







<p>- Olle E</p>


<br />
<p>On December 22nd, 2010, 1:21 p.m., Paul Belanger wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>


<p style="color: grey;"><i>Updated 2010-12-22 13:21:53</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A simple patch to detect when a DTMF feature from the AMI. Feedback on \
the event name is requested :)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Local dev box.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/CHANGES <span style="color: grey">(299001)</span></li>

 <li>trunk/main/features.c <span style="color: grey">(299001)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1065/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic