'[asterisk-dev] [Code Review] Rewrite callparking test'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] Rewrite callparking test
From:       "Paul Belanger" <reviewboard () asterisk ! org>
Date:       2010-12-17 20:54:49
Message-ID: 20101217205449.5284.51299 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1060/
-----------------------------------------------------------

Review request for Asterisk Developers.

Summary
-------

We now use the ParkedCall and UnParkedCall AMI events to track the status o=
f the test; this required patching starpy.  Additionally, I removed the 3rd=
 instance of Asterisk from this tests. I didn't see any real benefit to hav=
ing for this test.

Diffs
-----

  asterisk/trunk/tests/callparking/configs/ast1/extensions.conf 1246 =

  asterisk/trunk/tests/callparking/configs/ast1/features.conf PRE-CREATION =

  asterisk/trunk/tests/callparking/configs/ast1/iax.conf 1246 =

  asterisk/trunk/tests/callparking/configs/ast1/manager.conf PRE-CREATION =

  asterisk/trunk/tests/callparking/configs/ast2/extensions.conf 1246 =

  asterisk/trunk/tests/callparking/configs/ast2/iax.conf 1246 =

  asterisk/trunk/tests/callparking/configs/ast2/manager.conf PRE-CREATION =

  asterisk/trunk/tests/callparking/run-test 1246 =

  asterisk/trunk/tests/callparking/test-config.yaml 1246 =

Diff: https://reviewboard.asterisk.org/r/1060/diff

Testing
-------

local dev and FreeBSD box.

Thanks,

Paul

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1060/">https://reviewboard.asterisk.org/r/1060/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We now use the ParkedCall and UnParkedCall AMI events to track the \
status of the test; this required patching starpy.  Additionally, I removed the 3rd \
instance of Asterisk from this tests. I didn&#39;t see any real benefit to having for \
this test.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">local dev and FreeBSD box.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/tests/callparking/configs/ast1/extensions.conf <span \
style="color: grey">(1246)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast1/features.conf <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast1/iax.conf <span style="color: \
grey">(1246)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast1/manager.conf <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast2/extensions.conf <span \
style="color: grey">(1246)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast2/iax.conf <span style="color: \
grey">(1246)</span></li>

 <li>asterisk/trunk/tests/callparking/configs/ast2/manager.conf <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/callparking/run-test <span style="color: \
grey">(1246)</span></li>

 <li>asterisk/trunk/tests/callparking/test-config.yaml <span style="color: \
grey">(1246)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1060/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 