'Re: [asterisk-dev] [Code Review] MeetMe option for caching'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] MeetMe option for caching
From:       "Andrew Parisio" <reviewboard () asterisk ! org>
Date:       2010-11-24 22:29:25
Message-ID: 20101124222925.12957.58572 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1009/
-----------------------------------------------------------

(Updated 2010-11-24 16:29:25.466066)

Review request for Asterisk Developers.

Changes
-------

We changed this from option h to option v(oicemail).  I re-tested all features and \
verified file cleanup is correct in all cases, announcements work in all cases, etc.  \
Being my first commit I would appreciate it if somebody would take one last glance at \
this.

Thanks!

Summary
-------

I was looking for a feature to cache the recording of your name for when you use \
options I or i in meetme that announces a users name on entering and exiting a \
conference, this way users wouldn't have to do this every time. My goal with this is \
to auto-join members to a conference without them having to enter a pin or say their \
name, yet still have their name announced to the conference.  Instead of caching the \
file we use the users voicemail greet file from their mailbox, if the file does not \
exist then we unset the new flag in meetme (h), and it falls back to the old switches \
of i or I depending what you'd prefer for recording review/noreview.

Usage is like this: MeetMe(PIN,h(${CALLERID(num)}@default))

Diffs (updated)
-----

  /trunk/apps/app_meetme.c 294817 

Diff: https://reviewboard.asterisk.org/r/1009/diff

Testing
-------

I've tested with the users voicemail greet file there, and not there, with a \
combination of flags i or I being set.   I tested that i and I work properly without \
h set to ensure nothing i've added broke the old functionality.

I tested using the following commands with the greeting file being in the users \
mailbox, and the greeting file not being there. \
MeetMe(1,ih(${CALLERID(num)}@default)) MeetMe(1,Ih(${CALLERID(num)}@default))
MeetMe(1,i)
MeetMe(1,I)

Thanks,

Andrew

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1009/">https://reviewboard.asterisk.org/r/1009/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Andrew Parisio.</div>

<p style="color: grey;"><i>Updated 2010-11-24 16:29:25.466066</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We changed this from option h to option v(oicemail).  I re-tested all \
features and verified file cleanup is correct in all cases, announcements work in all \
cases, etc.  Being my first commit I would appreciate it if somebody would take one \
last glance at this.

Thanks!</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was looking for a feature to cache the recording of your name for when \
you use options I or i in meetme that announces a users name on entering and exiting \
a conference, this way users wouldn't have to do this every time. My goal with this \
is to auto-join members to a conference without them having to enter a pin or say \
their name, yet still have their name announced to the conference.  Instead of \
caching the file we use the users voicemail greet file from their mailbox, if the \
file does not exist then we unset the new flag in meetme (h), and it falls back to \
the old switches of i or I depending what you&#39;d prefer for recording \
review/noreview.

Usage is like this: MeetMe(PIN,h(${CALLERID(num)}@default))</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve tested with the users voicemail greet file there, and not \
there, with a combination of flags i or I being set.   I tested that i and I work \
properly without h set to ensure nothing i&#39;ve added broke the old functionality.

I tested using the following commands with the greeting file being in the users \
mailbox, and the greeting file not being there. \
MeetMe(1,ih(${CALLERID(num)}@default)) MeetMe(1,Ih(${CALLERID(num)}@default))
MeetMe(1,i)
MeetMe(1,I)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/apps/app_meetme.c <span style="color: grey">(294817)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1009/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 