[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Make http.c IPv6-ready
From:       "Simon Perreault" <simon.perreault () viagenie ! ca>
Date:       2010-10-29 20:39:18
Message-ID: 20101029203918.22458.17544 () hotblack ! digium ! com
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/986/#review2866
-----------------------------------------------------------

Ship it!


I tested it, it works. Excellent work!

- Simon


On 2010-10-29 14:56:37, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/986/
> -----------------------------------------------------------
> 
> (Updated 2010-10-29 14:56:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch allows for IPv6 addresses to be used when configuring the HTTP server in \
> Asterisk. 
> There is a behavior change here as well. Since ast_sockaddr_resolve() returns an \
> array of addresses, we'll iterate over the addresses returned until we're able to \
> properly start the server. Adding logic to fail back to a cached address was not \
> added, as the scope of that is quite different. 
> I rewrote a good portion of the configuration-loading function, so when reviewing, \
> be sure that I haven't introduced any subtle behavior changes. As a side note, it \
> would be awesome if we could just get rid of any "bindport" options, but I know \
> that would be hard to wrangle :) 
> As a side note, I noticed an odd inconsistency regarding setting the TLS and \
> non-TLS bind addresses. The non-TLS bind address can be a hostname, but the TLS one \
> cannot be, because it uses the built-in option parsing in tcptls.c. I did not \
> address this because I did not want the scope of my changes to be too broad. 
> 
> Diffs
> -----
> 
> /trunk/main/http.c 292864 
> 
> Diff: https://reviewboard.asterisk.org/r/986/diff
> 
> 
> Testing
> -------
> 
> None. I'm not in a position at the moment to be able to test very thoroughly.
> 
> 
> Thanks,
> 
> Mark
> 
> 


-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]