[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] MixMonitor external test
From:       "David Vossel" <dvossel () digium ! com>
Date:       2010-04-29 20:16:09
Message-ID: 20100429201609.9416.15165 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/632/
-----------------------------------------------------------

(Updated 2010-04-29 15:16:09.384984)


Review request for Asterisk Developers.


Changes
-------

Update includes verification that the second audiofile was released during hangup by \
the MixMonitor thread.  This is done through the addition of a second test extension. \
The new extension is called after a period of time to playback the second \
audiofile... If that playback is successful then we know the previous MixMonitor \
thread exited properly.


Summary
-------

MixMonitor external test.

Tests MixMonitor with StopMixMonitor, verifying that StopMixMonitor releases the \
audio file so it can be processed by the dialplan. Tests MixMonitor without \
StopMixMonitor, verifying that MixMonitor stops correctly on hangup. Tests the size \
of the two audio files to see if they are what we expect given the length of time \
processed.

Future improvements to this test will include using AUDIOHOOK_INHERIT.


Diffs (updated)
-----

  /asterisk/trunk/tests/mixmonitor/configs/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/mixmonitor/run-test PRE-CREATION 
  /asterisk/trunk/tests/mixmonitor/test-config.yaml PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/632/diff


Testing
-------

Test passes with trunk and 1.4


Thanks,

David


-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic