[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Explicit context set in SIP peer
From:       "Nick Lewis" <Nick.Lewis () atltelecom ! com>
Date:       2010-04-29 10:47:31
Message-ID: 20100429104731.31623.52741 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/565/#review1932
-----------------------------------------------------------


No quite that simple as p->relatedpeer->context will still be set if there is a \
default context and no peer context. There still needs to be a flag to distinguish \
these two situations so that the domain-context can be applied

- Nick


On 2010-04-28 02:20:23, pprindeville wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/565/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 02:20:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Having inbound SIP 'guest' calls associated to a default context is
> handy, especially when multi-tenancy or hosting multiple domains is
> being done.
> 
> However, the code as written will clobber an explicitly configured
> context associated with a peer if a domain-list is configured.
> 
> This is counter-intuitive, since (a) explicit configuration should
> always trump default or implicit config, and (b) puts all internal
> domain-bound SIP handsets in the same context as guest callers, making
> it hard to apply a restricted dialplan to guest callers.
> 
> 
> This addresses bug 17040.
> https://issues.asterisk.org/view.php?id=17040
> 
> 
> Diffs
> -----
> 
> branches/1.6.2/channels/chan_sip.c 258772 
> 
> Diff: https://reviewboard.asterisk.org/r/565/diff
> 
> 
> Testing
> -------
> 
> Running patched 1.6.2.6 on our production network.  Seems to work fine.
> 
> 
> Thanks,
> 
> pprindeville
> 
> 


-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]