[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Unit Test Framework
From:       "Russell Bryant" <russell () digium ! com>
Date:       2009-12-21 22:54:08
Message-ID: 20091221225408.15030.8268 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/447/#review1342
-----------------------------------------------------------

Ship it!


At this point, I'm happy for this to go into trunk.  I look forward to writing (and \
hassling others to write) lots of unit tests.  :-)

Nice work, David!


/trunk/include/asterisk/test.h
<https://reviewboard.asterisk.org/r/447/#comment3078>

    When you have a comment on the same line like this, you need to use the /*!< */ \
doxygen syntax.  
    However, I really prefer having the documentation on its own line.



/trunk/main/test.c
<https://reviewboard.asterisk.org/r/447/#comment3079>

    You can reduce indentation here:
    
    if (!args->cli) {
       return 0;
    }


- Russell


On 2009-12-21 16:31:03, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/447/
> -----------------------------------------------------------
> 
> (Updated 2009-12-21 16:31:03)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> The Unit Test Framework is a new API that manages registration and execution of \
> unit tests in Asterisk with the purpose of verifying the operation of C functions. 
> The Framework consists of a single test manager accompanied by a list of registered \
> test functions defined within the code.  A test is defined, registered, and \
> unregistered from the framework using a set of macros which allow the test code to \
> only be compiled within asterisk when the TEST_FRAMEWORK flag is enabled in \
> menuselect.  This allows the test code to exist in the same file as the C functions \
> it intends to verify.  Registered tests may be viewed and executed via a set of new \
> CLI commands.  CLI commands are also present for generating and exporting test \
> results into xml and txt formats. 
> For more information and use cases please refer to the documentation provided at \
> the beginning of the test.h file. 
> 
> Diffs
> -----
> 
> /trunk/build_tools/cflags-devmode.xml 236021 
> /trunk/include/asterisk/_private.h 236021 
> /trunk/include/asterisk/test.h PRE-CREATION 
> /trunk/main/asterisk.c 236021 
> /trunk/main/test.c PRE-CREATION 
> /trunk/tests/test_heap.c 236021 
> 
> Diff: https://reviewboard.asterisk.org/r/447/diff
> 
> 
> Testing
> -------
> 
> test_heap.c has been modified to take advantage of the Test Framework.  I have \
> executed and generated reports for these tests.  
> 
> Thanks,
> 
> David
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]