[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] SIP Contact ACL's return bad error
From:       "Kevin Fleming" <kpfleming () digium ! com>
Date:       2009-10-26 21:29:25
Message-ID: 20091026212925.18809.32760 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/415/#review1215
-----------------------------------------------------------

Ship it!


Other than the two very minor changes I've commented on, this looks good and is a \
welcome change. Thanks!


/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/415/#comment2826>

    Would you mind adding the IP address that the registration request arrived from \
to this message?



/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/415/#comment2825>

    Since the only way this condition can be reached involves another log message \
already being generated (that includes the peer name), this message (and the one like \
it just below) are probably redundant.


- Kevin


On 2009-10-26 15:37:33, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/415/
> -----------------------------------------------------------
> 
> (Updated 2009-10-26 15:37:33)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When a REGISTER is denied because of the Contact ACL's, we return an error code \
> that implies a bad format in the SIP request, which is wrong. This patch changes it \
> to a policy error. 
> THis error code is only sent after successful authentication, so it's not exposing \
> anything new. 
> This patch is for Asterisk 1.4. It needs to be merged in all branches from that up \
> to trunk. 
> 
> Diffs
> -----
> 
> /branches/1.4/channels/chan_sip.c 225916 
> 
> Diff: https://reviewboard.asterisk.org/r/415/diff
> 
> 
> Testing
> -------
> 
> Locally and at customer site.
> 
> 
> Thanks,
> 
> Olle E
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]