[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Optionally build apps in utils/
From:       "Kevin Fleming" <kpfleming () digium ! com>
Date:       2009-10-21 21:15:47
Message-ID: 20091021211547.30065.55773 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/353/#review1210
-----------------------------------------------------------

Ship it!


I'm fine with leaving astcanary in the menu to be disabled if someone wishes to, so I \
think this is ready to go as-is.

- Kevin


On 2009-09-04 11:09:11, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/353/
> -----------------------------------------------------------
> 
> (Updated 2009-09-04 11:09:11)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Based on a recent janitor submitted by oej, make the build of utilities optional
> based on selections made within menuselect.  The only change I could see being
> necessary before this gets committed is removing astcanary from the list of
> optional utilities and just building it every time.
> 
> 
> Diffs
> -----
> 
> /trunk/Makefile 216509 
> /trunk/utils/Makefile 216509 
> /trunk/utils/utils.xml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/353/diff
> 
> 
> Testing
> -------
> 
> Fired up menuselect, chose different utils to build, and built.
> 
> 
> Thanks,
> 
> Sean
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]