[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Added mohsuggest info to output
From:       "Sean Bright" <sean.bright () gmail ! com>
Date:       2009-09-30 14:24:13
Message-ID: 20090930142413.19196.19899 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/381/#review1124
-----------------------------------------------------------

Ship it!


Looks good.  Just add the new header to doc/manager.tex and update the patch on the \
bug tracker and we will get this committed.  Thanks.

- Sean


On 2009-09-29 17:59:54, _brent_ wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/381/
> -----------------------------------------------------------
> 
> (Updated 2009-09-29 17:59:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> the CLI command:
> 
> sip show peer {name}
> 
> now outputs information about the peer's mohsuggest setting in addition to all the \
> other stuff already being printed. Looks like this: 
> ...
> Pickupgroup :
> MOH Suggest : Rockout
> Mailbox : 7112@default
> ... 
> 
> 
> This addresses bug 0015990.
> https://issues.asterisk.org/view.php?id=0015990
> 
> 
> Diffs
> -----
> 
> /trunk/channels/chan_sip.c 220823 
> 
> Diff: https://reviewboard.asterisk.org/r/381/diff
> 
> 
> Testing
> -------
> 
> Added it, built it, ran it. It works. This doesn't really change any core \
> functionality. It just adds one line to some CLI informational output. Is there \
> anything else I should test? 
> 
> Thanks,
> 
> _brent_
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2009 - October 13 - 15 Phoenix, Arizona
Register Now: http://www.astricon.net

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]