[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] New signaling module to handle
From:       "Russell Bryant" <russell () digium ! com>
Date:       2009-05-29 16:12:17
Message-ID: 20090529161217.14795.41884 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/253/#review805
-----------------------------------------------------------

Ship it!


I pointed out a few formatting things in new/modified code.  Check for and fix other \
places with trailing whitespace or switch/case not aligned properly.

Also, we discussed IRL yesterday about adding some comments to places where commented \
out code is left in.  Please leave a note that explains why it is being left there so \
that someone else doesn't come behind you and remove it.

This code could certainly use some documentation love, but in this case, I'm okay \
with it going in without it for now.


/trunk/channels/chan_dahdi.c
<http://reviewboard.digium.com/r/253/#comment1989>

    minor whitespace issue



/trunk/channels/chan_dahdi.c
<http://reviewboard.digium.com/r/253/#comment1990>

    Align case and switch



/trunk/channels/sig_analog.h
<http://reviewboard.digium.com/r/253/#comment1991>

    Don't forget to fix these copyright headers to match the others in Asterisk.  I \
think you may have actually already done this in the branch ...



/trunk/channels/sig_analog.c
<http://reviewboard.digium.com/r/253/#comment1992>

    Align case and switch


- Russell


On 2009-05-26 12:58:44, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/253/
> -----------------------------------------------------------
> 
> (Updated 2009-05-26 12:58:44)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This branch splits all the analog signaling logic out of chan_dahdi.c into \
> sig_analog.c. Functionality in theory should not change at all. 
> 
> Diffs
> -----
> 
> /trunk/channels/Makefile 196825 
> /trunk/channels/chan_dahdi.c 196825 
> /trunk/channels/sig_analog.h PRE-CREATION 
> /trunk/channels/sig_analog.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/253/diff
> 
> 
> Testing
> -------
> 
> The main testing I did was simply making calls. Once I got that working most \
> everything else seemed to work. Specifically made sure caller id works for both \
> sending and receiving as well. 
> 
> Thanks,
> 
> Jeff
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]