[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Remove dead code in chan_agent
From:       "Russell Bryant" <russell () digium ! com>
Date:       2009-05-29 22:22:43
Message-ID: 20090529222243.8739.35778 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/267/#review811
-----------------------------------------------------------

Ship it!


- Russell


On 2009-05-29 09:01:06, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/267/
> -----------------------------------------------------------
> 
> (Updated 2009-05-29 09:01:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> AgentCallbacklogin was deprecated, but a lot of code regarding that functionality \
> wasn't removed. Agents are dump in the astdb only if there are logged in with \
> AgentCallbacklogin (not used code). ackcall could have three values:
> ackcall=yes, ackcall=always and ackcall=no Now it is not needed anymore leave \
> always for backward compatibility but make 'yes' work like 'always'. It is not \
> needed anymore to load agents from the astdb because we are not saving them. \
> loginchan is being used only by AgentCallbacklogin, is the user is logged with \
> AgentLogin then loginchan is NULL. 
> 
> Diffs
> -----
> 
> /trunk/channels/chan_agent.c 197925 
> /trunk/configs/agents.conf.sample 197925 
> 
> Diff: http://reviewboard.digium.com/r/267/diff
> 
> 
> Testing
> -------
> 
> Login an agent, receive a call from a queue with and without the ackcall option \
> setted. 
> 
> Thanks,
> 
> Eliel
> 
> 


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]