[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] hints with 2+ devices that include
From: "Russell Bryant" <russell () digium ! com>
Date: 2009-05-28 14:52:39
Message-ID: 20090528145239.31077.40758 () hotblack ! digium ! internal
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/254/#review803
-----------------------------------------------------------
The changes here look fine.
I think that it would be a great idea to write a test_devstate module that exercises \
the devstate_aggregate API with a bunch of different combinations of states and \
verifies that we get the expected results.
- Russell
On 2009-05-27 13:52:53, David Vossel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/254/
> -----------------------------------------------------------
>
> (Updated 2009-05-27 13:52:53)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This is a community patch I cleaned up and tested. Below is the reporter's, \
> p_lidheimer, description of the issue pulled directly from issue #15057.
> ----------------------------
> If you have a hint with two (or more) devices or a device and a custom devstate \
> that includes ONHOLD, you get unexpected results. Two examples:
> exten => 222,hint,SIP/222&SIP/211
> exten => 333,hint,Custom:DND333&SIP/333
>
> The following results are inconsistent as they should all return ONHOLD:
>
> ONHOLD & IDLE = IDLE
> ONHOLD & UNAVAILABLE => UNAVAILABLE
> ONHOLD & UNKNOWN => IDLE
> ONHOLD & INVALID => IDLE
>
> Per Russell Bryant's response on the mailing list:
>
> "I would agree that this is a bug. I would expect that combination of
> states to result in an OnHold state."
>
>
> This addresses bug 15057.
> https://issues.asterisk.org/view.php?id=15057
>
>
> Diffs
> -----
>
> /trunk/include/asterisk/devicestate.h 196415
> /trunk/main/devicestate.c 196415
>
> Diff: http://reviewboard.digium.com/r/254/diff
>
>
> Testing
> -------
>
> I have tested the patch and can verify the situations in the description all result \
> in ONHOLD.
>
> Thanks,
>
> David
>
>
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic