[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] unload/load/reload support for
From: "Russell Bryant" <russell () digium ! com>
Date: 2009-01-25 16:07:20
Message-ID: 20090125160720.11941.80598 () hotblack ! digium ! internal
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/130/#review313
-----------------------------------------------------------
trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment722>
It looks like this is done without protecting the lines list with a lock.
trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment723>
As a suggestion, you can collapse this down to ...
ast_verb(3, "%s config for line '%s'\n", l->name,
update ? "Updated" : (skinnyreload ? "Reloaded" : "Created"));
trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment724>
I see you go through the list removing devices and just throw them away. Should \
you be freeing them or something?
trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment725>
From a high level look at this function ...
1) It looks like no locking is being done to protect your list operations.
2) Keep in mind that it is possible for 2 reloads to be issued at the same time \
from different threads.
- Russell
On 2009-01-25 09:28:01, Michiel van Baak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/130/
> -----------------------------------------------------------
>
> (Updated 2009-01-25 09:28:01)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Add load/unload/reload support for chan_skinny
>
>
> This addresses bug 10297.
> http://bugs.digium.com/view.php?id=10297
>
>
> Diffs
> -----
>
> trunk/channels/chan_skinny.c 158753
>
> Diff: http://reviewboard.digium.com/r/130/diff
>
>
> Testing
> -------
>
> compiles and runs fine on OpenBSD 4.4 amd64
>
>
> Thanks,
>
> Michiel
>
>
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic