[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] CLI permissions
From:       Eliel_Sardañons <eliels () gmail ! com>
Date:       2008-11-28 19:05:36
Message-ID: 20081128190536.7146.56863 () hotblack ! digium ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/11/
-----------------------------------------------------------

(Updated 2008-11-28 13:05:36.768535)


Review request for Asterisk Developers.


Changes
-------

Sorry for all this updates to the review board:
- Make regular expression matching case insensitive.
- Explain that we can use regular expressions inside the configuration sample.


Summary
-------

Implement CLI permissions related to issue 11123.
I would like to receive an architectural review, if this is the right way to \
implement CLI permissions. I know there are some minor changes that need to be done \
(and others not so minor), maybe use RWLIST instead of a LIST, also trailing spaces, \
and a lot more, but If the architecture is ok, I will continue improving the code.

Thanks in advanced!


Diffs (updated)
-----

  /trunk/CHANGES 159772 
  /trunk/configs/cli_permissions.conf.sample PRE-CREATION 
  /trunk/configure.ac 159772 
  /trunk/include/asterisk/_private.h 159772 
  /trunk/include/asterisk/autoconfig.h.in 159772 
  /trunk/include/asterisk/cli.h 159772 
  /trunk/main/asterisk.c 159772 
  /trunk/main/cli.c 159772 

Diff: http://reviewboard.digium.com/r/11/diff


Testing
-------


Thanks,

Eliel


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[prev in list] [next in list] [prev in thread] [next in thread]