[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] mmichelson: trunk r125649
From:       Russell Bryant <russell () digium ! com>
Date:       2008-06-28 21:57:28
Message-ID: 555D9CEF-86ED-4A46-A56F-492A92346388 () digium ! com
[Download RAW message or body]


On Jun 28, 2008, at 4:36 PM, Eric Dantie wrote:
> As I see in
> http://www.asterisk.org/doxygen/1.4/pbx_8c.html#2a832efa9e38c1caef22f21336f16ea1
>
> pbx_builtin_getvar_helper() is already locking the channel, why does  
> it
> need to be locked before calling the function?


You're right.  I was the one that added that.  However, I later  
realized the channel actually needs to be locked outside of the call  
to getvar_helper().

The issue is that if the channel isn't locked, you can not safely read  
the result from the function.  The locking inside of it can be removed.

--
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.





_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2008 - September 22 - 25 Phoenix, Arizona
Register Now: http://www.astricon.net

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]