[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [asterisk-commits] russell: trunk r72701 - in
From:       Russell Bryant <russell () digium ! com>
Date:       2007-06-29 21:18:58
Message-ID: 46857742.4020405 () digium ! com
[Download RAW message or body]

Luigi Rizzo wrote:
> Hmmm... not 100% sure, but doesn't this kill HTTPS support, which
> requires to go through the fwrite() interface so it can use the
> encryption/decryption filter installed by fopencookie()/funopen() ?

You are absolutely correct.  Oops ...

> Frankly, I believe sendfile() is totally overkill here.
> This is asterisk, not a busy web server where you want to optimize
> large file transfers.
> 
> Surely the use of bounded size buffers is a worthwhile approach,
> but i'd suggest to just fix that part and get rid of sendfile.

That's fair.  I'll fix it up now.

Thanks for the feedback,

-- 
Russell Bryant
Software Engineer
Digium, Inc.

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]