[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-commits
Subject: [asterisk-commits] =?utf-8?q?Add_new_object_for_VoicemailUserEntr?= =?utf-8?q?y_=28asterisk=5Bmaster
From: SVN commits to the Asterisk project <asterisk-commits () lists ! digium ! com>
Date: 2017-12-06 2:10:51
Message-ID: mailman.1416.1512526294.1215.asterisk-commits () lists ! digium ! com
[Download RAW message or body]
Jenkins2 has submitted this change and it was merged=2E ( https://gerrit=2E=
asterisk=2Eorg/7428 )
Change subject: Add new object for VoicemailUserEntr=
y
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E
Add new ob=
ject for VoicemailUserEntry
Currently, when the app_voicemail sending Voic=
emailUserEntry AMI event, there's
no OldMessageCount info for default=2E
To=
check the OldMessageCount info, it required IMAP_STORAGE define, but this =
is
not correct=2E
Added OldMessageCount item as a default=2E
ASTERISK-2745=
6
Change-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7
---
M apps/app_voic=
email=2Ec
1 file changed, 4 insertions(+), 7 deletions(-)
Approvals:
Ben=
jamin Keith Ford: Looks good to me, but someone else must approve
Sean Br=
ight: Looks good to me, but someone else must approve
Kevin Harwell: Look=
s good to me, approved
Jenkins2: Approved for Submit
diff --git a/apps=
/app_voicemail=2Ec b/apps/app_voicemail=2Ec
index ecd423f=2E=2Ed017301 1006=
44
--- a/apps/app_voicemail=2Ec
+++ b/apps/app_voicemail=2Ec
@@ -13283,11 +=
13283,8 @@
AST_LIST_TRAVERSE(&users, vmu, list) {
char dirname[256]=
;
-#ifdef IMAP_STORAGE
int new, old;
-
inboxcount(vmu->mailbox, &new,=
&old);
-#endif
make_dir(dirname, sizeof(dirname), vmu->context, vmu=
->mailbox, "INBOX");
astman_append(s,
@@ -13319,8 +13316,8 @@
"MaxMe=
ssageCount: %d\r\n"
"MaxMessageLength: %d\r\n"
"NewMessageCount: %d=
\r\n"
-#ifdef IMAP_STORAGE
"OldMessageCount: %d\r\n"
+#ifdef IMAP_STORA=
GE
"IMAPUser: %s\r\n"
"IMAPServer: %s\r\n"
"IMAPPort: %s\r\n"
@=
@ -13353,14 +13350,14 @@
ast_test_flag(vmu, VM_OPERATOR) ? "Yes" : "No"=
,
vmu->maxmsg,
vmu->maxsecs,
+ new,
+ old
#ifdef IMAP_STORAGE
=
- new, old,
+ ,
vmu->imapuser,
vmu->imapserver,
vmu->imappo=
rt,
vmu->imapflags
-#else
- count_messages(vmu, dirname)
#endif
=
);
++num_users;
--
To view, visit https://gerrit=2Easterisk=2Eorg/7428=
To unsubscribe, visit https://gerrit=2Easterisk=2Eorg/settings
Gerrit-Pro=
ject: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Chan=
ge-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7
Gerrit-Change-Number: 7428=
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21@gmail=2Ecom>
Gerrit=
-Reviewer: Benjamin Keith Ford <bford@digium=2Ecom>
Gerrit-Reviewer: Jenkin=
s2
Gerrit-Reviewer: Kevin Harwell <kharwell@digium=2Ecom>
Gerrit-Reviewer: =
Sean Bright <sean=2Ebright@gmail=2Ecom>
[Attachment #3 (text/html)]
<p>Jenkins2 <strong>merged</strong> this change.</p><p><a \
href="https://gerrit.asterisk.org/7428">View Change</a></p><div \
style="white-space:pre-wrap">Approvals: Benjamin Keith Ford: Looks good to me, but \
someone else must approve Sean Bright: Looks good to me, but someone else must \
approve Kevin Harwell: Looks good to me, approved
Jenkins2: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add new \
object for VoicemailUserEntry<br><br>Currently, when the app_voicemail sending \
VoicemailUserEntry AMI event, there's<br>no OldMessageCount info for \
default.<br>To check the OldMessageCount info, it required IMAP_STORAGE define, but \
this is<br>not correct.<br>Added OldMessageCount item as a \
default.<br><br>ASTERISK-27456<br><br>Change-Id: \
I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7<br>---<br>M apps/app_voicemail.c<br>1 file \
changed, 4 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: \
monospace,monospace; white-space: pre-wrap;">diff --git a/apps/app_voicemail.c \
b/apps/app_voicemail.c<br>index ecd423f..d017301 100644<br>--- \
a/apps/app_voicemail.c<br>+++ b/apps/app_voicemail.c<br>@@ -13283,11 +13283,8 @@<br> \
<br> AST_LIST_TRAVERSE(&users, vmu, list) {<br> char dirname[256];<br>-#ifdef \
IMAP_STORAGE<br> int new, old;<br>-<br> inboxcount(vmu->mailbox, &new, \
&old);<br>-#endif<br> <br> make_dir(dirname, sizeof(dirname), \
vmu->context, vmu->mailbox, "INBOX");<br> astman_append(s,<br>@@ \
-13319,8 +13316,8 @@<br> "MaxMessageCount: %d\r\n"<br> \
"MaxMessageLength: %d\r\n"<br> "NewMessageCount: \
%d\r\n"<br>-#ifdef IMAP_STORAGE<br> "OldMessageCount: \
%d\r\n"<br>+#ifdef IMAP_STORAGE<br> "IMAPUser: %s\r\n"<br> \
"IMAPServer: %s\r\n"<br> "IMAPPort: %s\r\n"<br>@@ -13353,14 \
+13350,14 @@<br> ast_test_flag(vmu, VM_OPERATOR) ? "Yes" : \
"No",<br> vmu->maxmsg,<br> \
vmu->maxsecs,<br>+ new,<br>+ old<br> #ifdef IMAP_STORAGE<br>- new, \
old,<br>+ ,<br> vmu->imapuser,<br> vmu->imapserver,<br> \
vmu->imapport,<br> vmu->imapflags<br>-#else<br>- count_messages(vmu, \
dirname)<br> #endif<br> );<br> ++num_users;<br></pre><p>To view, visit <a \
href="https://gerrit.asterisk.org/7428">change 7428</a>. To unsubscribe, visit <a \
href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="https://gerrit.asterisk.org/7428"/><meta itemprop="name" content="View \
Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: \
I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7 </div> <div style="display:none"> \
Gerrit-Change-Number: 7428 </div> <div style="display:none"> Gerrit-PatchSet: 1 \
</div> <div style="display:none"> Gerrit-Owner: sungtae kim \
<pchero21@gmail.com> </div> <div style="display:none"> Gerrit-Reviewer: \
Benjamin Keith Ford <bford@digium.com> </div> <div style="display:none"> \
Gerrit-Reviewer: Jenkins2 </div> <div style="display:none"> Gerrit-Reviewer: Kevin \
Harwell <kharwell@digium.com> </div> <div style="display:none"> \
Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-commits mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-commits
--===============1756230350723950337==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic