[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-commits
Subject:    [asterisk-commits] =?utf-8?q?res_pjsip_outbound_publish=2Ec=3A_Fi?= =?utf-8?q?x_misplaced_parenthesi
From:       SVN commits to the Asterisk project <asterisk-commits () lists ! digium ! com>
Date:       2017-09-28 1:11:18
Message-ID: mailman.59798.1506624568.27840.asterisk-commits () lists ! digium ! com
[Download RAW message or body]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6613 )

Change subject: res_pjsip_outbound_publish.c: Fix misplaced parenthesis.
......................................................................

res_pjsip_outbound_publish.c: Fix misplaced parenthesis.

The pjsip_publishc_init() call was referenced with a misplaced
parentheses.  As a result, outbound publication messages went out with an
expiration of 1 second.

ASTERISK-27298

Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08
---
M res/res_pjsip_outbound_publish.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/res/res_pjsip_outbound_publish.c b/res/res_pjsip_outbound_publish.c
index 18525bf..0fac8ad 100644
--- a/res/res_pjsip_outbound_publish.c
+++ b/res/res_pjsip_outbound_publish.c
@@ -986,7 +986,7 @@
 
 	pj_cstr(&event, publish->event);
 	if (pjsip_publishc_init(publisher->client, &event, &server_uri, &from_uri, &to_uri,
-				publish->expiration != PJ_SUCCESS)) {
+			publish->expiration) != PJ_SUCCESS) {
 		ast_log(LOG_ERROR, "Failed to initialize publishing client on outbound publish '%s'\n",
 			ast_sorcery_object_get_id(publish));
 		pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);

-- 
To view, visit https://gerrit.asterisk.org/6613
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08
Gerrit-Change-Number: 6613
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett@digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp@digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com>

[Attachment #3 (text/html)]

<p>Jenkins2 <strong>merged</strong> this change.</p><p><a \
href="https://gerrit.asterisk.org/6613">View Change</a></p><div \
style="white-space:pre-wrap">Approvals:  Sean Bright: Looks good to me, but someone \
else must approve  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: \
pre-wrap;">res_pjsip_outbound_publish.c: Fix misplaced parenthesis.<br><br>The \
pjsip_publishc_init() call was referenced with a misplaced<br>parentheses.  As a \
result, outbound publication messages went out with an<br>expiration of 1 \
second.<br><br>ASTERISK-27298<br><br>Change-Id: \
I93622eabc8ee83e7a22e98c107f921284c605a08<br>---<br>M \
res/res_pjsip_outbound_publish.c<br>1 file changed, 1 insertion(+), 1 \
deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: \
pre-wrap;">diff --git a/res/res_pjsip_outbound_publish.c \
b/res/res_pjsip_outbound_publish.c<br>index 18525bf..0fac8ad 100644<br>--- \
a/res/res_pjsip_outbound_publish.c<br>+++ b/res/res_pjsip_outbound_publish.c<br>@@ \
-986,7 +986,7 @@<br> <br> 	pj_cstr(&amp;event, publish-&gt;event);<br> 	if \
(pjsip_publishc_init(publisher-&gt;client, &amp;event, &amp;server_uri, \
&amp;from_uri, &amp;to_uri,<br>-				publish-&gt;expiration != PJ_SUCCESS)) \
{<br>+			publish-&gt;expiration) != PJ_SUCCESS) {<br> 		ast_log(LOG_ERROR, \
&quot;Failed to initialize publishing client on outbound publish \
&#39;%s&#39;\n&quot;,<br> 			ast_sorcery_object_get_id(publish));<br> \
pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);<br></pre><p>To view, \
visit <a href="https://gerrit.asterisk.org/6613">change 6613</a>. To unsubscribe, \
visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="https://gerrit.asterisk.org/6613"/><meta itemprop="name" content="View \
Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: \
I93622eabc8ee83e7a22e98c107f921284c605a08 </div> <div style="display:none"> \
Gerrit-Change-Number: 6613 </div> <div style="display:none"> Gerrit-PatchSet: 1 \
</div> <div style="display:none"> Gerrit-Owner: Richard Mudgett \
&lt;rmudgett@digium.com&gt; </div> <div style="display:none"> Gerrit-Reviewer: \
Jenkins2 </div> <div style="display:none"> Gerrit-Reviewer: Joshua Colp \
&lt;jcolp@digium.com&gt; </div> <div style="display:none"> Gerrit-Reviewer: Sean \
Bright &lt;sean.bright@gmail.com&gt; </div>



-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-commits mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-commits
--===============6204676606233436690==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic