[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ast-users
Subject:    [ast-users] Typo in _SFOPEN macro?
From:       kpv () research ! att ! com (Phong Vo)
Date:       2006-06-01 0:31:33
Message-ID: 200606010431.AAA42678 () raptor ! research ! att ! com
[Download RAW message or body]


That's weird. That should have been (f)->endw = (f)->endr = (f)->data.
If the mode field is not plain SF_READ or SF_WRITE, the stream
should remain in a lock mode. However, that code is probably just
a precaution that seldom if ever gets invoked.

Phong

> From gsf@research.att.com Wed May 31 20:59:54 2006
> To: ast-users@research.att.com, zmsjeu47-kshtjdoyle@yahoo.com
> Subject: Re: [ast-users] Typo in _SFOPEN macro?
> Cc: kpv@research.att.com

> something's fishy
> I passed it on to kpv
> thanks

> On Wed, 31 May 2006 19:42:55 -0500 Terrence J. Doyle wrote:
> > The _SFOPEN macro in $INSTALLROOT/src/lib/libast/sfio/sfhdr.h is defined
> > as follows:

> > #define _SFOPEN(f)      ((f)->mode == SF_READ  ? _SFOPENRD(f) : \
> >                          (f)->mode == SF_WRITE ? _SFOPENWR(f) : \
> >                          ((f)->endr = (f)->endr = (f)->data) )

> > Is the double assignment to (f)->endr correct? Or should one of them be
> > (f)->endw?

> > Terrence Doyle

[prev in list] [next in list] [prev in thread] [next in thread]