[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    Re: cvs commit: apr/test testthread.c
From:       Ryan Bloom <rbb () covalent ! net>
Date:       2001-07-30 13:30:51
[Download RAW message or body]


I would like to test the accessor, but this didn't do that.  I am trying VERY hard
to remove all of the warnings from the test programs.  It would be cool to actually
write a test for that code though.

Ryan

On Sunday 29 July 2001 23:29, Aaron Bannert wrote:
> These were in there to test apr_thread_pool_get() (the accessor generated
> from the macro). Admittedly, it doesn't actually test if anything
> functional is working, but it does test that the macro is generating
> something syntatically and sematically correct (ie the types are ok).
>
> In my tree I'm actually using the variable so the -Wall warning goes away.
> I'll make sure something gets put in when i get the apr_thread_exit() fix
> commited.
>
> -aaron
>
> On Fri, Jul 27, 2001 at 07:21:39PM -0000, rbb@apache.org wrote:
> > rbb         01/07/27 12:21:39
> >
> >   Modified:    test     testthread.c
> >   Log:
> >   Remove unused pool variables from the testthread code.
> >
> >   Revision  Changes    Path
> >   1.19      +0 -4      apr/test/testthread.c
> >
> >   Index: testthread.c
> >   ===================================================================
> >   RCS file: /home/cvs/apr/test/testthread.c,v
> >   retrieving revision 1.18
> >   retrieving revision 1.19
> >   diff -u -r1.18 -r1.19
> >   --- testthread.c	2001/07/24 05:17:26	1.18
> >   +++ testthread.c	2001/07/27 19:21:39	1.19
> >   @@ -87,7 +87,6 @@
> >    void * APR_THREAD_FUNC thread_func1(apr_thread_t *thd, void *data)
> >    {
> >        int i;
> >   -    apr_pool_t *pool = apr_thread_pool_get(thd);
> >        for (i = 0; i < 10000; i++) {
> >            apr_lock_acquire(thread_lock);
> >            x++;
> >   @@ -100,7 +99,6 @@
> >    void * APR_THREAD_FUNC thread_func2(apr_thread_t *thd, void *data)
> >    {
> >        int i;
> >   -    apr_pool_t *pool = apr_thread_pool_get(thd);
> >        for (i = 0; i < 10000; i++) {
> >            apr_lock_acquire(thread_lock);
> >            x++;
> >   @@ -113,7 +111,6 @@
> >    void * APR_THREAD_FUNC thread_func3(apr_thread_t *thd, void *data)
> >    {
> >        int i;
> >   -    apr_pool_t *pool = apr_thread_pool_get(thd);
> >        for (i = 0; i < 10000; i++) {
> >            apr_lock_acquire(thread_lock);
> >            x++;
> >   @@ -126,7 +123,6 @@
> >    void * APR_THREAD_FUNC thread_func4(apr_thread_t *thd, void *data)
> >    {
> >        int i;
> >   -    apr_pool_t *pool = apr_thread_pool_get(thd);
> >        for (i = 0; i < 10000; i++) {
> >            apr_lock_acquire(thread_lock);
> >            x++;

-- 

_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------

[prev in list] [next in list] [prev in thread] [next in thread]