[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bapr=5D_ylavic_commented_on_pull_request_=2334=3A_F?= =?utf-8?q?ix_a_rare_s
From:       ylavic_(via_GitHub) <git () apache ! org>
Date:       2023-05-04 9:55:35
Message-ID: PR_kwDOAAJ05c4zcx6M-726e1ee7-fda1-488c-9fce-0d8383123f81 () gitbox ! apache ! org
[Download RAW message or body]


ylavic commented on PR #34:
URL: https://github.com/apache/apr/pull/34#issuecomment-1534446159

   apr_global_mutex_child_init() is not supposed to be called with `*mutex == NULL` \
(it should have been allocated with apr_global_mutex_create() first), so this is a \
usage/user error (i.e. don't do that)?  Also, if something has to be done with the \
new `APR_ENOLOCK` error from this PR, it should be possible to do the same by testing \
`*mutex == NULL` before in the caller, so I don't get what this PR is fixing, looks \
like defensive programming only to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]