[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    Re: svn commit: r1894621 - in /apr/apr/trunk: atomic/unix/builtins.c atomic/unix/builtins64.c atomic
From:       Yann Ylavic <ylavic.dev () gmail ! com>
Date:       2021-10-29 21:10:29
Message-ID: CAKQ1sVO6Z3NY91ShkSHxcz4WGkJxYi5TJ-Yp4EHqD9xTdRL_Nw () mail ! gmail ! com
[Download RAW message or body]

On Fri, Oct 29, 2021 at 8:00 PM Ruediger Pluem <rpluem@apache.org> wrote:
> 
> 
> 
> On 10/29/21 5:09 PM, ylavic@apache.org wrote:
> > Author: ylavic
> > Date: Fri Oct 29 15:09:13 2021
> > New Revision: 1894621
> > 
> > URL: http://svn.apache.org/viewvc?rev=1894621&view=rev
> > Log:
> > apr_atomic: Use __atomic builtins when available.
> > 
> > Unlike Intel's atomic builtins (__sync_*), the more recent __atomic builtins
> > provide atomic load and store for weakly ordered architectures like ARM32 or
> > powerpc[64], so use them when available (gcc 4.6.3+).
> > 
> > 
> > Modified:
> > apr/apr/trunk/atomic/unix/builtins.c
> > apr/apr/trunk/atomic/unix/builtins64.c
> > apr/apr/trunk/atomic/unix/mutex.c
> > apr/apr/trunk/configure.in
> > 
> 
> > 
> > Modified: apr/apr/trunk/atomic/unix/mutex.c
> > URL: http://svn.apache.org/viewvc/apr/apr/trunk/atomic/unix/mutex.c?rev=1894621&r1=1894620&r2=1894621&view=diff
> >  ==============================================================================
> > --- apr/apr/trunk/atomic/unix/mutex.c (original)
> > +++ apr/apr/trunk/atomic/unix/mutex.c Fri Oct 29 15:09:13 2021
> > @@ -89,7 +89,7 @@ static APR_INLINE apr_thread_mutex_t *mu
> > 
> > APR_DECLARE(apr_status_t) apr_atomic_init(apr_pool_t *p)
> > {
> > -    return apr__atomic_generic64_init(p);
> 
> Why is this no longer needed?

apr__atomic_generic64_init() is APR_SUCCESS when !APR_HAS_THREADS.

> 
> > +    return APR_SUCCESS;
> > }
> > 
> > #endif /* APR_HAS_THREADS */


Regards;
Yann.


[prev in list] [next in list] [prev in thread] [next in thread]