[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    Re: svn commit: r1894423 - /apr/apr/trunk/buckets/apr_brigade.c
From:       Graham Leggett <minfrin () sharp ! fm>
Date:       2021-10-21 12:49:07
Message-ID: 07E5E0AF-19E1-44E7-A089-00992CD35AE1 () sharp ! fm
[Download RAW message or body]

On 21 Oct 2021, at 12:57, Ruediger Pluem <rpluem@apache.org> wrote:

> > *
> > * Bump one byte off, and loop round to search again.
> > */
> > -        apr_bucket_split(e, 1);
> > -        APR_BUCKET_REMOVE(e);
> > -        APR_BRIGADE_INSERT_TAIL(bbOut, e);
> > -
> > -        outbytes++;
> > +        ignore++;
> 
> Don't we need to reset ignore to 0 after each
> 
> APR_BUCKET_REMOVE(e);
> APR_BRIGADE_INSERT_TAIL(bbOut, e);
> 
> in the code above as we start with a new bucket then again and should use the what \
> we read from it from the beginning?

Talked myself out of needing this, but we do yes.

Regards,
Graham
—


[prev in list] [next in list] [prev in thread] [next in thread]