[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    Re: svn commit: r1593614 - in /apr/apr/trunk: CHANGES configure.in memory/unix/apr_pools.c
From:       Stefan Fritsch <sf () sfritsch ! de>
Date:       2014-05-17 22:16:24
Message-ID: 1556644.NTEHZ9Igb5 () k
[Download RAW message or body]

On Thursday 15 May 2014 10:03:25, Ruediger Pluem wrote:
> > +    if (old == 2 && pool->in_use_by == apr_os_thread_current()) {
> 
> How can old ever be 2?

That was a leftover from a version with a separate state for the pool 
being cleared.

> 
> > +        /* cleanups may use the pool */
> > +        return;
> > +    }
> > +
> > +    if (old != 0)
> > +        pool_concurrency_abort(pool, __func__, old);
> 
> Isn't __func__ C99?


Thanks for the review. Both issues fixed in r1595549.

Stefan
[prev in list] [next in list] [prev in thread] [next in thread]