[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apr-dev
Subject:    Re: Any libtool/autoconf guru have 20 minutes to hack?
From:       "Henry Jen" <henryjen () ztune ! net>
Date:       2007-10-30 7:06:24
Message-ID: 369011d00710300006s4b2b4aa5j6a7320e78ca047bc () mail ! gmail ! com
[Download RAW message or body]

Attached is a patch giving the -version-info, works for me.

However, I am not sure if this is enough, as in ccs/ces, the libtool
is called with -avoid-version, which makes me suspicious the version
is left out on purpose.

HTH,
Henry

On 10/29/07, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> William A. Rowe, Jr. wrote:
> > libapriconv trunk would appreciate a small tweak here;
> >
> > apr.exp      libapr-1.so         libapriconv-1.so        libaprutil-1.so
> > aprutil.exp  libapr-1.so.0       libapriconv-1.so.0      libaprutil-1.so.0
> > iconv        libapr-1.so.0.2.12  libapriconv-1.so.0.0.0
> > libaprutil-1.so.0.2.12
> > libapr-1.a   libapriconv-1.a     libaprutil-1.a          pkgconfig
> > libapr-1.la  libapriconv-1.la    libaprutil-1.la
> >
> > Note it's not identified as libapriconv-1.so.0.2.1 (trunk rev from
> > api_version.h).
> >
> > I don't consider it a showstopper, but it would be nicer if we fixed before rolling
> > version 1.2.2.  The right hacker could do this in 1/10th the time it would take me
> > to figure this out :)
>
> ping?  any helper good at version decorations?
>

["apr-iconv_libtoolversion.diff" (text/x-patch)]

Index: configure.in
===================================================================
--- configure.in	(revision 589963)
+++ configure.in	(working copy)
@@ -90,6 +90,8 @@
 AC_SUBST(API_LIBNAME)
 API_INCPATH="apr-${API_MAJOR_VERSION}"
 AC_SUBST(API_INCPATH)
+LT_VERSION="-version-info `$get_version libtool $version_hdr API`"
+AC_SUBST(LT_VERSION)
 
 dnl
 dnl everthing is done. 
Index: lib/Makefile.in
===================================================================
--- lib/Makefile.in	(revision 589963)
+++ lib/Makefile.in	(working copy)
@@ -24,6 +24,7 @@
         iconv_ces.lo iconv_ces_euc.lo iconv_ces_iso2022.lo api_version.lo \
         iconv_ccs.lo exports.lo
 
+LT_VERSION = @LT_VERSION@
 # bring in rules.mk for standard functionality
 @INCLUDE_RULES@
 # replace build-outputs.mk


[prev in list] [next in list] [prev in thread] [next in thread]