[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apparmor-dev
Subject:    Re: [apparmor] [patch] Add support for rlimit and signal rules to aa-mergeprof
From:       Kshitij Gupta <kgupta8592 () gmail ! com>
Date:       2015-11-18 22:39:29
Message-ID: CAMBXP52_fcptyT+tr_imRV5=UKirey1xZEO-StgUZcoSr4T7pA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, Oct 23, 2015 at 9:04 PM, Christian Boltz <apparmor@cboltz.de> wrote:

> Hello,
>
> $subject ;-)
>
>
> [ 11-mergeprof-support-rlimit-and-signal.diff ]
>
> --- utils/aa-mergeprof  2015-06-25 21:32:37.420831338 +0200
> +++ utils/aa-mergeprof  2015-10-23 17:26:03.947428725 +0200
> @@ -631,7 +631,7 @@
>                              elif re.search('\d', ans):
>                                  default_option = ans
>
> -            for ruletype in ['capability', 'network', 'change_profile']:
> +            for ruletype in ['capability', 'change_profile', 'network',
> 'rlimit', 'signal']:
>
It might be a good idea to have the list of known rules stated right above
somewhere.


>                  if other.aa[profile][hat].get(ruletype, False): # needed
> until we have proper profile initialization
>                      for rule_obj in
> other.aa[profile][hat][ruletype].rules:
>
>
> Thanks for the patch.

Acked-by: Kshitij Gupta <kgupta8592@gmail.com>

>
>
> Regards,
>
> Christian Boltz
> --
> Schlagen. Verklagen. Z.B. bei der c't verpfeifen, auf daß es fortan
> die Spatzen von den Dächern pfeifen, was für Pfeifen das bei $Firma
> sind. *scnr* [David Haller in suse-linux]
>
>
> --
> AppArmor mailing list
> AppArmor@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/apparmor
>



-- 
Regards,

Kshitij Gupta

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct \
23, 2015 at 9:04 PM, Christian Boltz <span dir="ltr">&lt;<a \
href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <br>
$subject ;-)<br>
<br>
<br>
[ 11-mergeprof-support-rlimit-and-signal.diff ]<br>
<br>
--- utils/aa-mergeprof   2015-06-25 21:32:37.420831338 +0200<br>
+++ utils/aa-mergeprof   2015-10-23 17:26:03.947428725 +0200<br>
@@ -631,7 +631,7 @@<br>
                                            elif re.search(&#39;\d&#39;, ans):<br>
                                                  default_option = ans<br>
<br>
-                  for ruletype in [&#39;capability&#39;, &#39;network&#39;, \
&#39;change_profile&#39;]:<br> +                  for ruletype in \
[&#39;capability&#39;, &#39;change_profile&#39;, &#39;network&#39;, &#39;rlimit&#39;, \
&#39;signal&#39;]:<br></blockquote><div>It might be a good idea to have the list of \
known rules stated right above somewhere.<br></div><div>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
                rgb(204,204,204);padding-left:1ex">
                          if other.aa[profile][hat].get(ruletype, False): # needed \
                until we have proper profile initialization<br>
                                for rule_obj in \
other.aa[profile][hat][ruletype].rules:<br> <br>
<br></blockquote><div>Thanks for the patch.<br><br>Acked-by: Kshitij Gupta &lt;<a \
href="mailto:kgupta8592@gmail.com" target="_blank">kgupta8592@gmail.com</a>&gt; \
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
Schlagen. Verklagen. Z.B. bei der c&#39;t verpfeifen, auf daß es fortan<br>
die Spatzen von den Dächern pfeifen, was für Pfeifen das bei $Firma<br>
sind. *scnr* [David Haller in suse-linux]<br>
<br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a \
href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" \
target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij \
Gupta<br></div></div> </div></div>



-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor


[prev in list] [next in list] [prev in thread] [next in thread]