[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apparmor-dev
Subject:    Re: [apparmor] [patch] Re-enable check-logprof in profiles 'make check' target
From:       Kshitij Gupta <kgupta8592 () gmail ! com>
Date:       2015-06-19 18:54:41
Message-ID: CAMBXP53VhcAe9kU22CvPWbx_-JoMLqY--pLbkNr3zky-LKcGPQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

On Mon, Jun 15, 2015 at 4:21 AM, Christian Boltz <apparmor@cboltz.de> wrote:

> Hello,
>
> this patch re-enables check-logprof in the profiles 'make check' target.
>
> aa-logprof is able to parse all profiles, so there is no longer a
> reason to skip this test.
>
> This patch reverts r2097 and r2098 from 2013-01-02.
>
>
> [ profiles-enable-check-logprof.diff ]
>
> === modified file 'profiles/Makefile'
> --- profiles/Makefile   2015-01-23 23:52:09 +0000
> +++ profiles/Makefile   2015-06-14 22:41:37 +0000
> @@ -78,11 +78,8 @@
>  IGNORE_FILES=${EXTRAS_SOURCE}/README
>  CHECK_PROFILES=$(filter-out ${IGNORE_FILES} ${SUBDIRS}, $(wildcard
> ${PROFILES_SOURCE}/*) $(wildcard ${EXTRAS_SOURCE}/*))
>
> -# check-logprof is disabled here because it has not kept up with
> -# advances in the apparmor policy language. Re-enable when it is
> -# updated.
>  .PHONY: check
> -check: check-parser
> +check: check-parser check-logprof
>
>  .PHONY: check-parser
>  check-parser:
>
>

Thanks for the patch.

Acked-by: Kshitij Gupta <kgupta8592@gmail.com>.


>
>
> Regards,
>
> Christian Boltz
> --
> > But does your response also means that there is no concern if openSUSE
> > is left with no multimedia support normally provided from packman?
> Only if your psychic abilities surpass those of Miss Cleo and I'm the
> evil cousin of the wicked witch of the west. But who knows...
> [> Basil Chupin and Henne Vogelsang in opensuse-project]
>
>
> --
> AppArmor mailing list
> AppArmor@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/apparmor
>



-- 
Regards,

Kshitij Gupta

[Attachment #5 (text/html)]

<div dir="ltr">Hello,<br><div class="gmail_extra"><br><div class="gmail_quote">On \
Mon, Jun 15, 2015 at 4:21 AM, Christian Boltz <span dir="ltr">&lt;<a \
href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <br>
this patch re-enables check-logprof in the profiles &#39;make check&#39; target.<br>
<br>
aa-logprof is able to parse all profiles, so there is no longer a<br>
reason to skip this test.<br>
<br>
This patch reverts r2097 and r2098 from 2013-01-02.<br>
<br>
<br>
[ profiles-enable-check-logprof.diff ]<br>
<br>
=== modified file &#39;profiles/Makefile&#39;<br>
--- profiles/Makefile     2015-01-23 23:52:09 +0000<br>
+++ profiles/Makefile     2015-06-14 22:41:37 +0000<br>
@@ -78,11 +78,8 @@<br>
  IGNORE_FILES=${EXTRAS_SOURCE}/README<br>
  CHECK_PROFILES=$(filter-out ${IGNORE_FILES} ${SUBDIRS}, $(wildcard \
${PROFILES_SOURCE}/*) $(wildcard ${EXTRAS_SOURCE}/*))<br> <br>
-# check-logprof is disabled here because it has not kept up with<br>
-# advances in the apparmor policy language. Re-enable when it is<br>
-# updated.<br>
  .PHONY: check<br>
-check: check-parser<br>
+check: check-parser check-logprof<br>
<br>
  .PHONY: check-parser<br>
  check-parser:<br>
  <br></blockquote><div><br>Thanks for the patch.<br><br>Acked-by: Kshitij Gupta \
&lt;<a href="mailto:kgupta8592@gmail.com" \
target="_blank">kgupta8592@gmail.com</a>&gt;.     <br>  </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
&gt; But does your response also means that there is no concern if openSUSE<br>
&gt; is left with no multimedia support normally provided from packman?<br>
Only if your psychic abilities surpass those of Miss Cleo and I&#39;m the<br>
evil cousin of the wicked witch of the west. But who knows...<br>
[&gt; Basil Chupin and Henne Vogelsang in opensuse-project]<br>
<br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a \
href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" \
target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij \
Gupta<br></div></div> </div></div>



-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor


[prev in list] [next in list] [prev in thread] [next in thread]