[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apparmor-dev
Subject:    Re: [apparmor] [patch] delete unused functions check_include_syntax() and check_profile_syntax in aa
From:       Kshitij Gupta <kgupta8592 () gmail ! com>
Date:       2014-12-24 14:28:12
Message-ID: CAMBXP52eyMr_rVwJ_76E-K3MVmU4oLDaHCxYi9qDeMqhU8RiLQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

On Sun, Dec 7, 2014 at 2:54 AM, Christian Boltz <apparmor@cboltz.de> wrote:

> Hello,
>
> this patch deletes the unused functions check_include_syntax() and
> check_profile_syntax in aa.py
>
> [ aa.py-delete-unused-func.diff ]
>
> === modified file 'utils/apparmor/aa.py'
> --- utils/apparmor/aa.py        2014-11-29 12:40:10 +0000
> +++ utils/apparmor/aa.py        2014-12-06 21:22:07 +0000
> @@ -2560,14 +2560,6 @@
>          return True
>      return False
>
> -def check_include_syntax(errors):
> -    # To-Do
> -    pass
> -
> -def check_profile_syntax(errors):
> -    # To-Do
> -    pass
> -
>  def read_profiles():
>      try:
>          os.listdir(profile_dir)
>
>
> ahh so there was supposed to be a separate syntax parser for profile and
includes.
Would make sense but we deal with it at processing level now.
So,

Thanks for the cleanup.

Acked-by: Kshitij Gupta <kgupta8592@gmail.com>.

Regards,

Kshitij Gupta

>
>
> Regards,
>
> Christian Boltz
> --
> > > Dooooooooooooooooooch!!! ;-)
> > N<?php do{echo "e";>!
> cb@tux:~>  echo 'N<?php do{echo "e";>!' | php
> Parse error:  parse error, unexpected '>' in - on line 1
> [> Ratti und Christian Boltz in fontlinge-devel]
>
>
> --
> AppArmor mailing list
> AppArmor@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/apparmor
>

[Attachment #5 (text/html)]

<div dir="ltr">Hello,<br><div class="gmail_extra"><br><div class="gmail_quote">On \
Sun, Dec 7, 2014 at 2:54 AM, Christian Boltz <span dir="ltr">&lt;<a \
href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <br>
this patch deletes the unused functions check_include_syntax() and<br>
check_profile_syntax in aa.py<br>
<br>
[ aa.py-delete-unused-func.diff ]<br>
<br>
=== modified file &#39;utils/apparmor/aa.py&#39;<br>
--- utils/apparmor/aa.py            2014-11-29 12:40:10 +0000<br>
+++ utils/apparmor/aa.py            2014-12-06 21:22:07 +0000<br>
@@ -2560,14 +2560,6 @@<br>
              return True<br>
        return False<br>
<br>
-def check_include_syntax(errors):<br>
-      # To-Do<br>
-      pass<br>
-<br>
-def check_profile_syntax(errors):<br>
-      # To-Do<br>
-      pass<br>
-<br>
  def read_profiles():<br>
        try:<br>
              os.listdir(profile_dir)<br>
<br>
<br></blockquote><div>ahh so there was supposed to be a separate syntax parser for \
profile and includes. <br>Would make sense but we deal with it at processing level \
now.<br></div><div>So,<br><br></div><div>Thanks for the cleanup.<br><br>Acked-by: \
Kshitij Gupta &lt;<a href="mailto:kgupta8592@gmail.com" \
target="_blank">kgupta8592@gmail.com</a>&gt;.<br><br><div>Regards,<br><br></div>Kshitij \
Gupta<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
&gt; &gt; Dooooooooooooooooooch!!! ;-)<br>
&gt; N&lt;?php do{echo &quot;e&quot;;&gt;!<br>
cb@tux:~&gt;   echo &#39;N&lt;?php do{echo &quot;e&quot;;&gt;!&#39; | php<br>
Parse error:   parse error, unexpected &#39;&gt;&#39; in - on line 1<br>
[&gt; Ratti und Christian Boltz in fontlinge-devel]<br>
<br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a \
href="https://lists.ubuntu.com/mailman/listinfo/apparmor" \
target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br> \
</font></span></blockquote></div><br></div></div>



-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor


[prev in list] [next in list] [prev in thread] [next in thread]