[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apcupsd-users
Subject:    Re: [Apcupsd-users] Couple more warnings, updated patch
From:       Adam Kropelin <adam () kroptech ! com>
Date:       2014-03-22 17:44:19
Message-ID: CADAPGLpsQwL83tDFJdY=mmXr0+74Gx6RY6ctaweG77WUAp7Wvw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Mar 20, 2014 at 8:32 PM, Timothe Litt <litt@acm.org> wrote:

>  On another machine, a couple more compile warnings:
>
>   CXX   src/drivers/usb/usb.c
> usb.c: In member function =E2bool UsbUpsDriver::usb_process_value_bup(int=
,
> UsbUpsDriver::USB_VALUE*)=E2:
> usb.c:292:71: warning: narrowing conversion of =E2((val >> 16) & 255)=E2 =
from
> =E2int=E2 to =E2char=E2 inside { } is ill-formed in C++11 [-Wnarrowing]
> usb.c:292:71: warning: narrowing conversion of =E2((val >> 8) & 255)=E2 f=
rom
> =E2int=E2 to =E2char=E2 inside { } is ill-formed in C++11 [-Wnarrowing]
> usb.c:292:71: warning: narrowing conversion of =E2(val & 255)=E2 from =E2=
int=E2 to
> =E2char=E2 inside { } is ill-formed in C++11 [-Wnarrowing]
>

Thanks, fixed.


> Building 3.14.11 from source on Fedora Core 17+:  halt is no longer a sys=
V
> script.
>
> I think that something needs to be done in final.target
> (/usr/lib/systemd/system/final*) to handle the killpower - but as at the
> moment, this is a VM, I'm going to ignore it.  If someone has made the
> adaptations for systemd, please contribute them....
>

Seconded. Due to lack of time I pretty much have to stay off the
distro-and-version-specific upgrade treadmill.


> I noticed that the scripts are tailored from .in versions, so here's an
> updated patch that applies the same changes to the .in files :
>

Patch applied, thanks.

--Adam

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Mar 20, 2014 \
at 8:32 PM, Timothe Litt <span dir="ltr">&lt;<a href="mailto:litt@acm.org" \
target="_blank">litt@acm.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

  

    
  
  <div text="#000000" bgcolor="#FFFFFF">
    On another machine, a couple more compile warnings:<br>
    <br>
      CXX   src/drivers/usb/usb.c<br>
    usb.c: In member function âbool
    UsbUpsDriver::usb_process_value_bup(int, UsbUpsDriver::USB_VALUE*)â:<br>
    usb.c:292:71: warning: narrowing conversion of â((val &gt;&gt; 16)
    &amp; 255)â from âintâ to âcharâ inside { } is ill-formed in C++11
    [-Wnarrowing]<br>
    usb.c:292:71: warning: narrowing conversion of â((val &gt;&gt; 8)
    &amp; 255)â from âintâ to âcharâ inside { } is ill-formed in C++11
    [-Wnarrowing]<br>
    usb.c:292:71: warning: narrowing conversion of â(val &amp; 255)â
    from âintâ to âcharâ inside { } is ill-formed in C++11 \
[-Wnarrowing]<br></div></blockquote><div><br></div><div>Thanks, fixed.</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF">
    Building 3.14.11 from source on Fedora Core 17+:  halt is no longer
    a sysV script.<br>
    <br>
    I think that something needs to be done in final.target
    (/usr/lib/systemd/system/final*) to handle the killpower - but as at
    the moment, this is a VM, I&#39;m going to ignore it.  If someone has
    made the adaptations for systemd, please contribute \
them....<br></div></blockquote><div><br></div><div>Seconded. Due to lack of time I \
pretty much have to stay off the distro-and-version-specific upgrade treadmill.</div> \
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">  I noticed that \
the scripts are tailored from .in versions, so here&#39;s  an updated patch that \
applies the same changes to the .in files \
:<br></div></blockquote><div><br></div><div>Patch applied, \
thanks.</div><div><br></div><div>--Adam</div><div><br></div></div></div></div>



------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

_______________________________________________
Apcupsd-users mailing list
Apcupsd-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/apcupsd-users


[prev in list] [next in list] [prev in thread] [next in thread]