[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-stdcxx-issues
Subject:    [jira] Created: (STDCXX-1016) __rw::__rw_mutex
From:       "Farid Zaripov (JIRA)" <jira () apache ! org>
Date:       2008-09-17 13:17:45
Message-ID: 1239686113.1221657465010.JavaMail.jira () brutus
[Download RAW message or body]

__rw::__rw_mutex __rw::__rw_locale::_C_mutex member currentry is not used
-------------------------------------------------------------------------

                 Key: STDCXX-1016
                 URL: https://issues.apache.org/jira/browse/STDCXX-1016
             Project: C++ Standard Library
          Issue Type: Improvement
          Components: 22. Localization
    Affects Versions: 4.2.1, 4.2.0, 4.1.4, 4.1.3
         Environment: All
            Reporter: Farid Zaripov
            Assignee: Farid Zaripov
            Priority: Trivial
             Fix For: 4.2.2


Currently the _C_mutex data member of the __rw::__rw_locale class is mentioned only \
in _C_add_ref () and _C_remove_ref () methods of this class. But neither _C_add_ref \
() nor _C_remove_ref () are not invoked from anywhere.

The proposed patch:

{noformat}
Index: src/locale_body.h
===================================================================
--- src/locale_body.h	(revision 695985)
+++ src/locale_body.h	(working copy)
@@ -91,8 +91,6 @@
     // (i.e., one with the same id) in the locale object
     _RWSTD_SIZE_T _C_byname_facet_bits;
 
-    __rw_mutex    _C_mutex;
-
     friend struct _STD::locale;
 
 public:
@@ -165,14 +163,6 @@
         return _RWSTD_ATOMIC_PREDECREMENT (__facet._C_ref, false);
     }
 
-    _RWSTD_SIZE_T _C_add_ref () {
-        return _RWSTD_ATOMIC_PREINCREMENT (_C_ref, _C_mutex);
-    }
-
-    _RWSTD_SIZE_T _C_remove_ref () {
-        return _RWSTD_ATOMIC_PREDECREMENT (_C_ref, _C_mutex);
-    }
-
     // access private facet name
     static const char* _C_get_cat_name (const __rw_facet &__facet) {
         return __facet._C_name;
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[prev in list] [next in list] [prev in thread] [next in thread]