[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-modperl-docs-dev
Subject:    Re: tiny patch to user/install/install.pod
From:       Stas Bekman <stas () stason ! org>
Date:       2004-12-15 1:01:56
Message-ID: 41BF8D04.80701 () stason ! org
[Download RAW message or body]

Brandt Kurowski wrote:
> howdy folks,
> 
> i just learned the hard way that makepl_args.mod_perl2 needs
> newlines between the options, whereas mod_perl1 worked fine
> with just spaces. seems worth documenting:

Thanks Brandt, but I'd rather see this fixed in the code :)

Please try this patch:

Index: lib/ModPerl/BuildOptions.pm
===================================================================
--- lib/ModPerl/BuildOptions.pm (revision 111891)
+++ lib/ModPerl/BuildOptions.pm (working copy)
@@ -75,7 +75,13 @@
      my @unknown;
      my $continue = "";

+    my @data = ();
      for (@$lines) {
+        # more than one entry on the same line
+        push @data, split /(?=MP_)/, $_;
+    }
+
+    for (@data) {
          #XXX: this "parser" should be more robust
          chomp;
          s/^\s+//; s/\s+$//;



-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]